Allow for dynamic port usage for local rpc endpoint if 17071 in use #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still want to do some end-to-end testing for this PR in Functions V2 and V3, and make sure it doesn't break anything in V1. |
cgillum
approved these changes
Apr 7, 2020
davidmrdavid
approved these changes
Apr 8, 2020
Our initial implementation of Local HTTP for out-of-proc languages always uses the port 17071. This can cause issues with slots, as well as caused some noisy telemetry when hosts would shut down occasionally. We now check to see if the default port is available before attempting to bind to it. There is still some degree of race condition if the extensions are instantiated before the port is being listened to, but in general the OS should provide some protections against this.
ConnorMcMahon
force-pushed
the
AddPortDiscoveryLocalRpc
branch
from
bdf181f to
44bf3fb
Compare
|
Tested in FunctionsV1 and FunctionsV3 to be sure neither broke (Functions V1 due to conditional compilation, FunctionsV3 to verify no synchronous calls in HTTP pipeline). Also tested end-to-end in Durable JS, and verified using RPC URI with a different port. |
|
is there any way of getting my hands on this fix? I've had a durable function go down without warning and cannot start even after deleting and recreating the app because of this port in use error |
|
Related: #1273 |
ConnorMcMahon
pushed a commit
that referenced
this pull request
Jun 6, 2020
Port PR #1307 to Durable 1.x
ConnorMcMahon
pushed a commit
that referenced
this pull request
Jun 12, 2020
Port PR #1307 to Durable 1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our initial implementation of Local HTTP for out-of-proc languages always uses the port 17071. This can cause issues with slots, as well as caused some noisy telemetry when hosts would shut down occasionally.
We now check to see if the default port is available before attempting to bind to it. There is still some degree of race condition if the extensions are instantiated before the port is being listened to, but in general the OS should provide some protections against this.