Adding Missing Fields to Linux Logger: ProviderName, TaskName, ActivityId, RelatedActivityId, StampName, etc #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
reviewed
Oct 6, 2020
davidmrdavid
changed the title
davidmrdavid
changed the title
davidmrdavid
changed the title
davidmrdavid
commented
Oct 6, 2020
davidmrdavid
commented
Oct 6, 2020
| Assert.Contains("EventId", keys); | ||
| Assert.Contains("TimeStamp", keys); | ||
| Assert.Contains("RoleInstance", keys); | ||
| Assert.Contains("Tenant", keys); | ||
| Assert.Contains("SourceMoniker", keys); |
There was a problem hiding this comment.
this is what was breaking the test in master
davidmrdavid
commented
Oct 6, 2020
Comment on lines
+435
to
+438
| Assert.Contains("EventStampName", keys); | ||
| Assert.Contains("EventPrimaryStampName", keys); | ||
| Assert.Contains("ProviderName", keys); | ||
| Assert.Contains("TaskName", keys); |
There was a problem hiding this comment.
the rest of this PR should enable us to additionally also log these 4 properties in linux. That's it!
bachuv
approved these changes
Oct 6, 2020
davidmrdavid
added a commit
that referenced
this pull request
Jan 28, 2021
…tyId, RelatedActivityId, StampName, etc (#1515)
davidmrdavid
added a commit
that referenced
this pull request
Jan 28, 2021
…tyId, RelatedActivityId, StampName, etc (#1515)
davidmrdavid
added a commit
that referenced
this pull request
Jan 28, 2021
* Replace the impl of Syscall.rename and remove Mono.Posix.NETStandard (follow-up to #1641) (#1643) Co-authored-by: Tatsuro Shibamura <me@shibayan.jp> * Adding Missing Fields to Linux Logger: ProviderName, TaskName, ActivityId, RelatedActivityId, StampName, etc (#1515) * Linux Logger now supports the legacy regex logging path (#1522) "It's done, it's finally done" - Frodo Co-authored-by: David Justo <dajusto@microsoft.com> Co-authored-by: Chris Gillum <cgillum@microsoft.com> * Replace the impl of Syscall.rename and remove Mono.Posix.NETStandard (follow-up to #1641) (#1643) Co-authored-by: Tatsuro Shibamura <me@shibayan.jp> * Shift tracing inside conditional check * Added Tracing options, project compiles * Disable verbosity check in V1 * Remove unecessary xml file, remove release notes, update release version, update azurestorage * Update azurestorage refs in test csprojs * downgrade back to azurestorage 1.7.7 Co-authored-by: Tatsuro Shibamura <me@shibayan.jp> Co-authored-by: David Justo <dajusto@microsoft.com> Co-authored-by: Chris Gillum <cgillum@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally a small test PR, but now it's grown in scope
This PR adds missing fields to our LinuxLogger class, providing now a fuller scope of logs and, hopefully, enough to make our telemetry and existing diagnostics tools more effective in debugging linux apps.
The logging validation test has been updated accordingly