Fix AD0001 warning in Durable Analyzer #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2020 15:49
A small typo in PR #1494 resulted in the analyzer failing to load due to an argument exception. Fixing this typo fixes the problem. A future PR should be add a test to make sure this doesn't regress in the future.
bachuv
reviewed
Oct 6, 2020
src/WebJobs.Extensions.DurableTask.Analyzers/WebJobs.Extensions.DurableTask.Analyzers.csproj
Show resolved
Hide resolved
bachuv
approved these changes
Oct 6, 2020
|
@ConnorMcMahon before merging this, note that no CI tests are running automatically at the moment so please trigger a run for this tests manually before merging. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
I did it manually via the website, btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small typo in PR #1494 resulted in the analyzer failing to load due to
an argument exception. Fixing this typo fixes the problem.
A future PR should be add a test to make sure this doesn't regress in the
future.