Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect documentation for ReadEntityStateAsync() #1637

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Fix incorrect documentation for ReadEntityStateAsync() #1637

merged 2 commits into from
Jan 15, 2021

Conversation

ConnorMcMahon
Copy link
Contributor

@ConnorMcMahon ConnorMcMahon commented Jan 8, 2021 •
edited
Loading

Remove the section about state above 16KB returning default(T), which
has never been true after entities went GA.

Resolves #1631

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Fix incorrect documentation for ReadEntityStateAsync()
c90091c 
Remove the section about state above 16KB returning default(T), which
has never been true after entities went GA.

Fixes #1631
@ConnorMcMahon ConnorMcMahon merged commit 60e8a71 into dev Jan 15, 2021
@ConnorMcMahon ConnorMcMahon deleted the Fix1631 branch January 15, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachuv bachuv bachuv approved these changes

@sebastianburckhardt sebastianburckhardt Awaiting requested review from sebastianburckhardt

@amdeel amdeel Awaiting requested review from amdeel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadEntityStateAsync xml comments mentions 16KB limit for returning serialized state
2 participants
@ConnorMcMahon @bachuv