Register IPlatformInformationService in AddDurableClientFactory() #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
approved these changes
Mar 12, 2021
ConnorMcMahon
approved these changes
Mar 12, 2021
| public async Task DurableClient_AzureStorage_SuccessfulSetup() | ||
| { | ||
| string orchestratorName = nameof(TestOrchestrations.SayHelloInline); | ||
| using (ITestHost host = TestHelpers.GetJobHost( |
There was a problem hiding this comment.
In the long run, we may be able to simplify this test (and the additional helper methods we added) by making a generic .NET Core host that calls builder.Services.AddDurableClientFactory();. That is more inline with what end customers would be doing, and then you don't need all of the changes to TestHelpers to accommodate wiring this into the JobHost.
In the interest of time and the code freeze today, I am fine postponing this.
amdeel
suggested changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes incorporate the changes from #1706 and register
IPlatformInformationServiceinAddDurableClientFactory(). Without registeringIPlatformInformationService, creating a DurableClient with Azure Storage fails because it can't find an implementation ofIPlatformInformationServiceinAzureStorageDurabilityProviderFactory. This PR also includes a test in DurableClientBaseTests to help us catch if any new services need to be registered inAddDurableClientFactory()in the future.Pull request checklist
pending_docs.mdrelease_notes.md