Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small documentation update for CodeGeneration for Durable Functions #1864

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

KeesV
Copy link
Contributor

@KeesV KeesV commented Jun 3, 2021

Small update to the documentation for CodeGeneration for Durable Functions

  • Remove instruction to mark the reference with specific attributes, as these attributes only make sense when adding a Project Reference, and we're talking about a PackageReference here
  • Add <EmitCompilerGeneratedFiles> to make sure generated code is actually output somewhere

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@KeesV KeesV changed the title Patch 1 Small documentation update for CodeGeneration for Durable Functions Jun 3, 2021
Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for these changes, a lot of tweaks were made at the last minute to this project so I'm not surprised there were small gaps like these. Thanks for your contributions!

@ConnorMcMahon ConnorMcMahon merged commit cc7f8b2 into Azure:dev Jun 4, 2021
@KeesV KeesV deleted the patch-1 branch June 7, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants