Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer: Added binding analyzer, updated entity interface content analyzer, fixed argument exception #1968

Merged
merged 8 commits into from
Oct 26, 2021

Conversation

amdeel
Copy link
Contributor

@amdeel amdeel commented Oct 5, 2021

Analyzer updates for 0.4.1 release:

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk

Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nit picks and a few questions. I think this is pretty close to merging!

Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amdeel amdeel changed the title Analyzer: Added binding analyzer, updated entity interface content analyzer Analyzer: Added binding analyzer, updated entity interface content analyzer, fixed argument exception Oct 26, 2021
@amdeel amdeel merged commit 8919c3e into dev Oct 26, 2021
@amdeel amdeel deleted the analyzerUpdates branch October 27, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants