-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analyzer: Added binding analyzer, updated entity interface content analyzer, fixed argument exception #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amdeel
commented
Oct 12, 2021
src/WebJobs.Extensions.DurableTask.Analyzers/Analyzers/Orchestrator/DateTimeAnalyzer.cs
Outdated
Show resolved
Hide resolved
amdeel
commented
Oct 18, 2021
src/WebJobs.Extensions.DurableTask.Analyzers/SyntaxNodeUtils.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nit picks and a few questions. I think this is pretty close to merging!
...bJobs.Extensions.DurableTask.Analyzers/Analyzers/EntityInterface/InterfaceContentAnalyzer.cs
Show resolved
Hide resolved
src/WebJobs.Extensions.DurableTask.Analyzers/Analyzers/Orchestrator/BindingAnalyzer.cs
Show resolved
Hide resolved
src/WebJobs.Extensions.DurableTask.Analyzers/SyntaxNodeUtils.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Extensions.DurableTask.Analyzers/SyntaxNodeUtils.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Extensions.DurableTask.Analyzers/SyntaxNodeUtils.cs
Outdated
Show resolved
Hide resolved
ConnorMcMahon
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
amdeel
changed the title
Analyzer: Added binding analyzer, updated entity interface content analyzer
Analyzer: Added binding analyzer, updated entity interface content analyzer, fixed argument exception
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyzer updates for 0.4.1 release:
Incremented version to 0.4.1
Updated Entity InterfaceContentAnalyzer to avoid flagging interfaces that implement another interface.
Added BindingAnalyzer to deterministic method checks, flagging all attributes used on parameters that are not OrchestrationTrigger to prevent customers from using additional bindings on their orchestrator method.
Fixed ArgumentException thrown in SyntaxUtils.TryGetSemanticModelForSyntaxTree that occurred when the SyntaxNode being analyzed was not in the current compilation by creating a new compilation that adds the syntax tree for the syntax node. Also added a catch block in TryGetSemanticModelForSyntaxTree for language version mismatches.
Pull request checklist
pending_docs.md
release_notes.md