Fix spurious validation errors for non-Azure-Storage backends #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Factory if the provider is not configured for use.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Some tests are consistently failing. Investigating now. It looks like the problem is that some tests are using custom provider types, such as AzureStorageShortenedTimerDurabilityProviderFactory, so my code is overly simplistic (I cannot simply check whether the storage provider is the default provider or not). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor of AzureStorageDurabilityProviderFactory performs validation on the options, even if this provider is not the provider that is actually selected for use.
This causes problems with spurious validation exceptions, e.g. with the Netherite provider if the latter uses more than 16 partitions.
This fix performs a check in the constructor of AzureStorageDurabilityProviderFactory to see if it is actually the selected provider, and skips the constructor if not. This avoids spurious errors caused by the configuration not being appropriate for this provider.
Issue describing the changes in this PR
resolves #2013
Pull request checklist
release_notes.md