Use AspNetCore.Http 2.1.x track on netstandard2.0 #2417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently been informed by an automated dependency scan that AspNetCore.Http 2.2.x is affected by CVE-2020-1045
.
This CVE was resolved in AspNetCore.Http 2.1.x but not in AspNetCore.Http 2.2.x. This is apparently because the 2.2.x track went EOL before 2.1.x.
From my understanding thus far, this CVE may also be ignored when .NET Core app 3.1 or greater is used. This is still to be confirmed.
Given that our project uses multi-targeting, one target being netstandard2.0 and another being netcoreapp3.1, this PR only addresses the vulnerability in the netstandard2.0 target. This PR does this by downgrading our AspNetCore dependencies to the 2.1.x track, and pinning to the AspNetCore.Http version with the CVE fix.
Question: do we need to backport this change to DF V1?
Issue describing the changes in this PR
resolves N/A
Pull request checklist
pending_docs.md
release_notes.md
/src/Worker.Extensions.DurableTask/AssemblyInfo.cs