fix translation of legacy query to new entity query support #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
reviewed
Oct 19, 2023
| @@ -641,7 +641,7 @@ async Task<EntityQueryResult> IDurableEntityClient.ListEntitiesAsync(EntityQuery | |||
| var result = await entityBackendQueries.QueryEntitiesAsync( | |||
| new EntityBackendQueries.EntityQuery() | |||
| { | |||
| InstanceIdStartsWith = query.EntityName != null ? $"${query.EntityName}" : null, | |||
| InstanceIdStartsWith = query.EntityName != null ? $"@{query.EntityName.ToLowerInvariant()}@" : null, | |||
There was a problem hiding this comment.
Do we need to check if it already has @ suffix and prefix?
There was a problem hiding this comment.
not in this case... EntityName is already the entity name only, it was defined a bit differently for that query.
|
This PR now also pulls in the fixes from preview.2 that were merged in Azure/durabletask#999 |
davidmrdavid
approved these changes
Oct 19, 2023
sebastianburckhardt
added a commit
that referenced
this pull request
Oct 19, 2023
* udpate readme. * update durability provider class for new core-entities support. (#2570) * update durability provider class for new core-entities support. * add configuration setting for max entity concurrency to DurableTaskOptions * minor fixes. * update DurableClient to take advantage of native entity queries (#2571) * update DurableClient to take advantage of native entity queries if available * fix minor errors. * address PR feedback * implement passthrough middleware for entities (#2572) * implement passthrough middleware for entities. * propagate changes to protocol * update/simplify protobuf format * address PR feedback * implement entity queries for grpc listener (#2573) * implement entity queries for grpc listener * propagate changes to protocol * update/simplify protobuf format * Various fixes (#2585) * durability provider must implement and pass-through IEntityOrchestrationService since it wraps the orchestration service * simple mistake * fix misunderstanding of initializer syntax (produced null, not empty list) * fix missing failure details * fix missing compile-time switch for trigger value type * fix missing optional arguments * fix missing override * simplify how entities are excluded from instance queries (#2586) * add an entity example to the DotNetIsolated smoke test project. (#2584) * add an entity example to the DotNetIsolated smoke test project. * remove superfluous argument. * address PR feedback * Entities: Add worker side entity trigger and logic (#2576) * Add worker side entity trigger and logic * update comments * Address PR comments * another small fix that got lost somewhere. (#2596) * Update packages and version for entities preview (#2599) * Switch to Microsoft.DurableTask.Grpc (#2605) * Fix grpc core (#2616) * pass entity parameters for task orchestration. (#2611) * Core entities/various fixes and updates (#2619) * assign the necessary AzureStorageOrchestrationServiceSettings * propagate changes to query name and metadata parameters * add missing override for TaskOrchestrationEntityFeature * Update to entities preview 2 (#2620) * Add callback handler for entity dispatching (#2624) * Core entities/propagate changes (#2625) * add configuration for EnableEntitySupport * rename includeStateless to includeTransient * Rev dependencies to entities-preview.2 (#2627) * Call EnsureLegalAccess from EntityFeature in dotnet-isolated (#2633) * create a better error message in situations where client entity functions are called on a backend that does not support entities (#2630) * Rev package versions, update release notes (#2638) * Address smoke test build issue (#2647) * fix translation of legacy query to new entity query support (#2648) * fix translation of legacy query to new entity query support * comment out CleanEntityStorage_Many * try to enable CI on feature branch * Revert "comment out CleanEntityStorage_Many" This reverts commit aeaa4b8. * update to preview.2 packages --------- Co-authored-by: Varshitha Bachu <vabachu@microsoft.com> Co-authored-by: Jacob Viau <javia@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in how entity queries are translated to the new entity query support in
IEntityOrchestrationService.Pull request checklist
tracked with feature branch.