Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MaxQueuePollingInterval default for Flex Consumption apps #2953

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

bachuv
Copy link
Collaborator

@bachuv bachuv commented Nov 7, 2024

This PR updates the MaxQueuePollingInterval to a default of 1 second instead of 30 seconds if the app is running on a Flex Consumption plan to help with cold start latency specific to Durable Functions Flex Consumption apps.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v3.x branch.
    • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me! I think we just need to add some code comments explaining why we have this new logic (to remind our future selves and/or future maintainers).

@cgillum
Copy link
Member

cgillum commented Nov 8, 2024

Oh, and let's make sure we update the release notes with this information so that we have this change nicely documented for people to see.

cgillum and others added 2 commits November 21, 2024 13:56
This addresses an issue where the costs associated with polling storage resources increase substantially when an app has a large number of durable-trigger functions compared to apps that only have a small number.
@bachuv bachuv marked this pull request as ready for review December 3, 2024 19:55
@bachuv bachuv changed the base branch from dev to v3.x December 3, 2024 20:33
@bachuv bachuv merged commit 62f1d13 into v3.x Dec 3, 2024
6 checks passed
@bachuv bachuv deleted the vabachu/update-polling-for-flex branch December 3, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants