APIs to enumerate all orchestration instances #323

TsuyoshiUshio · 2018-05-30T09:48:06Z

I start this pull request to start conversation.
This pull request is for this issue.

Also, related this pull request for DurableTask

NOTE

If you do CI for this pull request, currently it must fail. This fix need the code change of the durable task pull request. I write a code with the nuget packages of DurableTask.AzureStorage (2.0.0.5) I don't include csproj file since it is changed to load local file.

I have some questions for you.

Should I change the version of the DurableTaskStorage? or leave it to you?
For writing test, we need to add method to the DurableOrchestrationClientMock.cs. However, it is just mplement DurableOrchestrationClientBase. As we discuss, currently, I use cast for avoiding change of DurableTask.Core. I can't change the mock. Should I leave test? then implement after change the TaskHubClient?

Anyway, this is the first steps. :) Please review this before go deep. :)

cgillum

This is looking great! I'm very excited about this feature. I would like to request a few small changes to make sure the performance remains good.

Also, I think it would be a good idea to create a built-in REST API that can also invoke this. You can add it to HttpApiHandler.cs, just like we do for the other GetStatus methods.

Lastly, let's make sure to add some tests for this new feature.

cgillum · 2018-05-30T23:42:21Z

src/WebJobs.Extensions.DurableTask/DurableOrchestrationClient.cs

+            var tasks = new List<Task<DurableOrchestrationStatus>>();
+            foreach (var state in states)
+            {
+                tasks.Add(this.GetDurableOrchestrationStatusAsync(state, showHistory, showHistoryOutput));


I worry that this could cause thread-pool starvation because we're potentially starting an unlimited number of tasks in parallel. I looked at the implementation of GetDurableOrchestrationStatusAsync, and it appears that it only does async work if showHistory is true. Otherwise, it completes quickly and synchronously. To avoid risk, can we remove showHistory and showHistoryOutput from this new API and set it always to false when calling GetDurableOrchestrationStatusAsync? I think getting the history of every instance at the same time will not be necessary for the DevOps scenarios we are interested in, and this will make sure we do not explode our thread usage.

If we make this suggested change, then I think you can get rid of Task.WhenAll and just add items to the list one at a time.

Thank you, Make sense. I push some changes. One of the problem is GetDurableOrchestrationStatusAsync has too much responsibilities. I extract the conversion part. It doesn't have async/await operation. Then it might help people understand the code more.

cgillum · 2018-05-30T23:46:32Z

src/WebJobs.Extensions.DurableTask/DurableOrchestrationClient.cs

+            // TODO this cast is to avoid to change DurableTask.Core. Change it to use TaskHubClient.
+            var serviceClient = (DurableTask.AzureStorage.AzureStorageOrchestrationService)this.client.serviceClient;
+            var states = await serviceClient.GetOrchestrationStateAsync(cancellationToken);
+            var tasks = new List<Task<DurableOrchestrationStatus>>();


By default, the Task<T> class will create a list size of some small number, maybe 4 or 11, I forget. If we add more items than this, Task<T> will silently discard its internal buffer, create a new one of double size, and copy all the items from the first buffer to the new buffer. It will keep doing this until we finish adding elements to the list. This is very inefficient and can cause performance problems with the .NET Garbage Collector. The best practice is to use the List<T>(int) constructor overload to specify an initial list capacity that meets our needs. In this case, I think you should say the following:

var result = new List<DurableOrchestrationStatus>(states.Count);

Oh, no. I didn't know that. That is why people use List(int) ... I double check the spec. However, this code has gone. :) Now no problem.

cgillum · 2018-05-30T23:48:38Z

src/WebJobs.Extensions.DurableTask/DurableOrchestrationClientBase.cs

+        /// </summary>
+        /// <param name="showHistory">Boolean marker for including execution history in the response.</param>
+        /// <param name="showHistoryOutput">Boolean marker for including input and output in the execution history response.</param>
+        /// <param name="cancellationToken">Cancel your request by this token</param>


I would phrase this token a little differently to match the passive wording style of the other parameter descriptions. For example:

Cancellation token that can be used to cancel the status query operation.

Thanks. Done it.

…yload

TsuyoshiUshio · 2018-05-31T11:26:37Z

Hi @cgillum ,

I wrote code for HttpApiHandler and HttpApiHandlerTest.

I have two questions for the architecture.

I add an attribute to the StatusResponsePayload (instanceId) is it fine?
I change the HttpApiHandler.HandleRequestAsync for adding the case of GetStatusAsync(). is it fine?

I intend that the url might be /instances/ with Get request, it returns all instances. It works, however, it is not intuitive on the code.

            string path = request.RequestUri.AbsolutePath.TrimEnd('/');
            int i = path.IndexOf(InstancesControllerSegment, StringComparison.OrdinalIgnoreCase);
            if (i < 0)
            {
                // Retrive All Status in case of the request URL ends e.g. /instances/
                if (request.Method == HttpMethod.Get
                    && path.IndexOf(InstancesControllerSegment.TrimEnd('/'), StringComparison.OrdinalIgnoreCase) >= 0)
                {
                    return await this.HandleGetStatusRequestAsync(request);
                }

                return request.CreateResponse(HttpStatusCode.NotFound);
            }

cgillum

Regarding your questions:

Yes, adding InstanceId is great - thanks for doing this.
Yes, I think this is necessary.

I apologize that the HTTP request path handling is not very simple. It might be over-optimized for performance.

I left some feedback on the code. In general this looks very good and I think we're close to merging it. Let me know if your tests are passing locally and we can go ahead and get started on the DurableTask.AzureStorage publishing.

cgillum · 2018-05-31T16:11:52Z

src/WebJobs.Extensions.DurableTask/HttpApiHandler.cs

+            }
+            catch (Exception e)
+            {
+                return request.CreateErrorResponse(HttpStatusCode.InternalServerError, "Internal Server Error", e);


I believe this is the default behavior, so no need to have this try/catch.

cgillum · 2018-05-31T16:26:17Z

src/WebJobs.Extensions.DurableTask/HttpApiHandler.cs

@@ -104,6 +105,13 @@ public HttpApiHandler(DurableTaskExtension config, ILogger logger)
            int i = path.IndexOf(InstancesControllerSegment, StringComparison.OrdinalIgnoreCase);
            if (i < 0)
            {
+                // Retrive All Status in case of the request URL ends e.g. /instances/
+                if (request.Method == HttpMethod.Get
+                    && path.IndexOf(InstancesControllerSegment.TrimEnd('/'), StringComparison.OrdinalIgnoreCase) >= 0)


Not sure if this is 100% correct. Does GET /instances12345 also resolve to this API? What about GET /FooBarInstances? Maybe you can simply do an equality check.

if (request.Method == HttpMethod.Get && path.Equals(InstancesControllerSegment.TrimEnd('/'), StringComparison.OrdinalIgnoreCase)

Sorry about that. I fixed that.

I've done that.

cgillum · 2018-05-31T16:26:42Z

src/WebJobs.Extensions.DurableTask/HttpApiHandler.cs

@@ -115,7 +123,7 @@ public HttpApiHandler(DurableTaskExtension config, ILogger logger)
                string instanceId = path.Substring(i);
                if (request.Method == HttpMethod.Get)
                {
-                    return await this.HandleGetStatusRequestAsync(request, instanceId);
+                        return await this.HandleGetStatusRequestAsync(request, instanceId);


Looks like some extra whitespace got added?

cgillum · 2018-05-31T16:32:48Z

src/WebJobs.Extensions.DurableTask/HttpApiHandler.cs

+            try
+            {
+                DurableOrchestrationClientBase client = this.GetClient(request);
+                var status = await client.GetStatusAsync();


In cases where the type of the variable is not obvious, I prefer we use the actual type name instead of var. It makes the code more easily understandable to others. In this case, I would prefer:

List<DurableOrchestrationStatus> statusForAllInstances = await client.GetStatusAsync();

I apologize that the convention is not consistently used everywhere.

Sorry about that. I should have notice that. For statusForAllInstances naming is good to know! I was wondering which is the good naming for this. Done!

cgillum · 2018-05-31T16:34:43Z

test/HttpApiHandlerTests.cs

+                    Method = HttpMethod.Get,
+                    RequestUri = getStatusRequestUriBuilder.Uri,
+                });
+            var actual = JsonConvert.DeserializeObject<IList<StatusResponsePayload>>(await responseMessage.Content.ReadAsStringAsync());


Before this, I suggest you add a check for HTTP 200 status code.

cgillum · 2018-05-31T16:36:59Z

src/WebJobs.Extensions.DurableTask/StatusResponsePayload.cs

+        /// InstanceId.
+        /// </summary>
+        [DataMember(Name = "instanceId")]
+        public JToken InstanceId { get; set; }


This should be string, not JToken.

TsuyoshiUshio · 2018-06-02T15:50:54Z

Hi @cgillum , I've done all.

cgillum · 2018-06-02T18:10:39Z

src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj

@@ -32,6 +28,11 @@
    <Compile Include="..\..\.stylecop\GlobalSuppressions.cs" Link="GlobalSuppressions.cs" />
  </ItemGroup>

+  <ItemGroup>
+    <PackageReference Include="DurableTask.AzureStorage" Version="1.2.2" />
+    <PackageReference Include="DurableTask.Core" Version="2.0.0.5" />


It's not necessary to reference DurableTask.Core explicitly. Referencing DurableTask.AzureStorage is sufficient.

cgillum · 2018-06-02T18:11:05Z

test/WebJobs.Extensions.DurableTask.Tests.csproj

@@ -33,4 +33,8 @@
    <Compile Include="$(SolutionDir)\.stylecop\GlobalSuppressions.cs" Link="GlobalSuppressions.cs" />
  </ItemGroup>

+  <ItemGroup>
+    <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />


Do you know what this is?

I don't know. It is not my intent. When I search the internet ... element, I found it is a notation to tell vs that this project is test project with 3rd party library.
https://stackoverflow.com/questions/18614342/what-is-service-include-in-a-csproj-file-for

Shall we remove this or keep this?

Since it wasn't there originally and you didn't add it intentionally, I would remove it.

cgillum · 2018-06-02T18:13:07Z

src/WebJobs.Extensions.DurableTask/HttpApiHandler.cs

                if (request.Method == HttpMethod.Get
-                    && path.IndexOf(InstancesControllerSegment.TrimEnd('/'), StringComparison.OrdinalIgnoreCase) >= 0)
+                    && string.Equals(path?.Substring(indexOfSegment), InstancesControllerSegment.TrimEnd('/'), StringComparison.OrdinalIgnoreCase))


Isn't it simpler to just say string.Equals(path, InstancesControllerSegment.TrimEnd('/'), StringComparison.OrdinalIgnoreCase)? I don't think you need the indexOfSegment variable.

Why we need this is, path is not "/Instances/". Actually it is "/admin/extensions/DurableTaskExtension/Instances". Since the InstancesControllerSegment is "/Instances/" we need to do Substring it.

Oh, you're right! Sorry - my bad. Would path.EndsWith(InstancesControllerSegment.TrimEnd('/'), StringComparison.OrdinalIgnoreCase) work? If so, that might be a little more efficient.

It is much cooler than my code. :) Thanks! Done

TsuyoshiUshio · 2018-06-03T04:04:42Z

Hi @cgillum ,
I add some comment and done a fix for DurableTask.Core's one. Please have a look.

cgillum · 2018-06-03T22:25:30Z

I responded to some of your comments, but generally I think this looks ready. If everything is working for you locally, let's go ahead and merge your DurableTask.AzureStorage changes in the durabletask repo. I will publish the nuget package to our staging location, and then you can update this PR to reference the newest version. That should allow the CI to start working.

If the CI succeeds, then I will go ahead and publish the latest DurableTask.AzureStorage to nuget.org and we can merge this PR.

cgillum · 2018-06-05T00:14:42Z

OK, a package with your DurableTask.AzureStorage change has been added here: https://www.myget.org/feed/azure-appservice/package/nuget/DurableTask.AzureStorage. Can you please update your reference to point to 1.2.3? Our CI should be searching myget for packages automatically.

TsuyoshiUshio · 2018-06-05T02:39:43Z

Hi @cgillum , One question, when I build locally, It requires DurableTask.Core 2.0.0.6. (I tried DurableTask.Core 2.0.0.5 however, it doesn't work). I remember that you said DurableTask.Core is not required. Do I missing something?

TsuyoshiUshio · 2018-06-05T02:54:43Z

It works on the CI. However, not for my local. lol. If I add DurableTask.Core 2.0.0.6 it might work. Unless the DurableTask.Core, I have this error. Is it some kind of cache issue?

Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0012	The type 'OrchestrationState' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.	WebJobs.Extensions.DurableTask(net461), WebJobs.Extensions.DurableTask(netstandard2.0)	C:\Users\tsushi\Codes\AzureFunctions\pullrequest\azure-functions-durable-extension\src\WebJobs.Extensions.DurableTask\DurableOrchestrationClient.cs	164	Active

cgillum · 2018-06-05T04:19:21Z

According to the link I shared previously, DurableTask.Core 2.0.0.5 is the required dependency. There is no 2.0.0.6. Did you add a NuGet package source for https://www.myget.org/F/azure-appservice/api/v3/index.json in your Visual Studio? You need to add that in order to download the new package locally.

TsuyoshiUshio · 2018-06-05T04:46:03Z

I have it on the NuGet.config and Package source. I'll ask @gled4er about it tomorrow.

<?xml version="1.0" encoding="utf-8"?>

<configuration>
  <packageSources>
    <add key="nuget.org" value="https://www.nuget.org/api/v2/" />
    <add key="azure-appservice" value="https://www.myget.org/F/azure-appservice/api/v3/index.json" />
  </packageSources>
</configuration>

TsuyoshiUshio · 2018-06-06T04:02:13Z

Hi @cgillum , Do we need some push to start full-ci?

cgillum · 2018-06-06T05:08:40Z

The full CI already ran and is already green. Were you able to get everything working locally?

TsuyoshiUshio · 2018-06-06T14:02:10Z

Hi @cgillum

No only my local machine has problem.

I've done a lot of work around, however, I can't solve this problem. When I build it I've got this error.

1>------ Build started: Project: WebJobs.Extensions.DurableTask, Configuration: Debug Any CPU ------
1>DurableOrchestrationClient.cs(164,32,164,72): error CS0012: The type 'OrchestrationState' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableOrchestrationClient.cs(166,35,166,41): error CS1579: foreach statement cannot operate on variables of type '?' because '?' does not contain a public instance definition for 'GetEnumerator'
1>DurableTaskExtension.cs(267,38,267,51): error CS0012: The type 'IOrchestrationService' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableTaskExtension.cs(267,38,267,51): error CS0012: The type 'IOrchestrationServiceClient' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableTaskExtension.cs(267,52,267,77): error CS1503: Argument 1: cannot convert from 'DurableTask.AzureStorage.AzureStorageOrchestrationService' to 'DurableTask.Core.IOrchestrationService'
1>DurableTaskExtension.cs(270,13,270,61): error CS0012: The type 'IOrchestrationService' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableTaskExtension.cs(270,13,270,61): error CS0012: The type 'IOrchestrationServiceClient' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableTaskExtension.cs(270,62,270,87): error CS1503: Argument 1: cannot convert from 'DurableTask.AzureStorage.AzureStorageOrchestrationService' to 'DurableTask.Core.IOrchestrationService'
1>DurableTaskExtension.cs(422,32,422,58): error CS0012: The type 'IOrchestrationServiceClient' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableTaskExtension.cs(422,59,422,70): error CS1503: Argument 1: cannot convert from 'DurableTask.AzureStorage.AzureStorageOrchestrationService' to 'DurableTask.Core.IOrchestrationServiceClient'
1>DurableOrchestrationClient.cs(169,14,170,1): warning SA1513: Closing brace should be followed by blank line
1>DurableOrchestrationClientBase.cs(46,13,46,27): warning SA1648: inheritdoc should be used with inheriting class
1>DurableOrchestrationClientBase.cs(57,13,57,27): warning SA1648: inheritdoc should be used with inheriting class
1>Done building project "WebJobs.Extensions.DurableTask.csproj" -- FAILED.
1>DurableOrchestrationClient.cs(164,32,164,72): error CS0012: The type 'OrchestrationState' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableOrchestrationClient.cs(166,35,166,41): error CS1579: foreach statement cannot operate on variables of type '?' because '?' does not contain a public instance definition for 'GetEnumerator'
1>DurableTaskExtension.cs(267,38,267,51): error CS0012: The type 'IOrchestrationService' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableTaskExtension.cs(267,38,267,51): error CS0012: The type 'IOrchestrationServiceClient' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableTaskExtension.cs(267,52,267,77): error CS1503: Argument 1: cannot convert from 'DurableTask.AzureStorage.AzureStorageOrchestrationService' to 'DurableTask.Core.IOrchestrationService'
1>DurableTaskExtension.cs(270,13,270,61): error CS0012: The type 'IOrchestrationService' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableTaskExtension.cs(270,13,270,61): error CS0012: The type 'IOrchestrationServiceClient' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableTaskExtension.cs(270,62,270,87): error CS1503: Argument 1: cannot convert from 'DurableTask.AzureStorage.AzureStorageOrchestrationService' to 'DurableTask.Core.IOrchestrationService'
1>DurableTaskExtension.cs(422,32,422,58): error CS0012: The type 'IOrchestrationServiceClient' is defined in an assembly that is not referenced. You must add a reference to assembly 'DurableTask.Core, Version=2.0.0.5, Culture=neutral, PublicKeyToken=d53979610a6e89dd'.
1>DurableTaskExtension.cs(422,59,422,70): error CS1503: Argument 1: cannot convert from 'DurableTask.AzureStorage.AzureStorageOrchestrationService' to 'DurableTask.Core.IOrchestrationServiceClient'
1>DurableOrchestrationClient.cs(169,14,170,1): warning SA1513: Closing brace should be followed by blank line
1>DurableOrchestrationClientBase.cs(46,13,46,27): warning SA1648: inheritdoc should be used with inheriting class
1>DurableOrchestrationClientBase.cs(57,13,57,27): warning SA1648: inheritdoc should be used with inheriting class
1>Done building project "WebJobs.Extensions.DurableTask.csproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

I changed a version of VS, remove bin/obj directory, or remove ~/.nuget/packages/durabletask.azurestorage and durabletask.core . Everytime it fails. Once I install Durabletask.Core manually from Manage nuget package, it works.

When I see the C:\Users\tsushi\.nuget\packages\durabletask.core\2.0.0.5\lib\netstandard2.0 I can find DurableTask.Core.dll on the Visual Studio, Dependencies\NetStandard 2.0\NuGet\DurableTask.AzureStorage(1.2.3)\DurableTask.Core(2.0.0.5) and it all looks fine. I don't know why this is missing reference. Any ideas?

TsuyoshiUshio · 2018-06-06T14:09:43Z

Hi @cgillum ,

I finally figured out why it happens. I left the old DurableTask.Core on my LocalNuGet dir. Maybe it is precedent than the network repo.

cgillum · 2018-06-06T14:15:36Z

It's odd that it works in the CI but not locally. Could it be related to the order in which it looks for packages across different package sources on your machine? For example, if you list nuget.org first before myget, does it work? I suspect the problem could be that DurableTask.AzureStorage is looking for a DurableTask.Core with a strong name, but maybe there is a version of DurableTask.Core myget which doesn't have a strong name. I've seen similar build problems in the past caused by this.

cgillum · 2018-06-06T14:16:25Z

Oh, glad you figured it out!

TsuyoshiUshio · 2018-06-06T14:22:04Z

Hi @cgillum ,

I tested this branch locally. It works!
Now ready to merge this and review the document pull request!

TsuyoshiUshio · 2018-06-06T14:26:52Z

@cgillum
Year, the order of my package sources are
nuget.org
azure-appservice (v2)
Local Package Source
azure-appservice (v3)
Microsoft Visual Studio Offline Packages. Personally, I'll research the nuget behavior.

TsuyoshiUshio · 2018-06-07T22:06:16Z

Hi @cgillum
Do we have any other TODO?
If not, let's merge it. :)

cgillum · 2018-06-07T22:30:06Z

I think we've covered everything! The only caveat is that the required DurableTask.AzureStorage v1.2.3 package is currently only in MyGet, and not in nuget.org. I will move it to nuget.org a little bit later if that's not a problem.

Thanks for this awesome PR!! This one was tricky because it involved changes across two different repos, but I'm glad we got through it.

TsuyoshiUshio · 2018-06-07T23:00:14Z

Thank you for the review. I enjoyed a lot. I'll go on the next PR. lol

Requires DurableTask.AzureStorage v1.2.3 or greater

Add new interface for the DurableOrchestrationClient

b01b61e

cgillum requested changes May 30, 2018

View reviewed changes

cgillum changed the title ~~On the fly Orchestrator status~~ APIs to enumerate all orchestration instances May 30, 2018

TsuyoshiUshio added 4 commits May 31, 2018 11:22

Refactor for avoiding thread-pool starvation

b711151

doc wording into passive to match the other parameter style

af2997b

Implement HttpApiHandler.cs

161b0a3

Adding test for GetStatus. Also add one attribute to StatusResponsePa…

264cb55

…yload

cgillum reviewed May 31, 2018

View reviewed changes

TsuyoshiUshio added 6 commits June 2, 2018 23:25

Remove try/catch since this is default behavior

c22cc6f

fix: make it perfect match

c77ca6b

Remove white space

3b77418

refactor the parameter name

c7b6dc8

fix in case of /instancesabc should not match

7e48fcf

change JToken to string

96574bf

cgillum reviewed Jun 2, 2018

View reviewed changes

Remove DurableTask.Core

ca6c70c

TsuyoshiUshio added 2 commits June 4, 2018 09:27

Remove not intended ItemGroup

e282881

Refactor the code for efficiency

4f5ab02

Update the library.

136abf3

TsuyoshiUshio added 2 commits June 5, 2018 11:42

Remove the DurableTask.Core

09ba206

Update the unit test project

6bf426c

cgillum added the full-ci label Jun 5, 2018

cgillum approved these changes Jun 7, 2018

View reviewed changes

cgillum merged commit 6a29105 into Azure:dev Jun 7, 2018

TsuyoshiUshio mentioned this pull request Jun 8, 2018

Improve versioning documentation #320

Open

cgillum pushed a commit that referenced this pull request Jun 21, 2018

APIs to enumerate all orchestration instances (#323)

95bef02

Requires DurableTask.AzureStorage v1.2.3 or greater

APIs to enumerate all orchestration instances #323

APIs to enumerate all orchestration instances #323

Conversation

TsuyoshiUshio commented May 30, 2018

NOTE

cgillum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TsuyoshiUshio commented May 31, 2018

cgillum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TsuyoshiUshio commented Jun 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TsuyoshiUshio commented Jun 3, 2018

cgillum commented Jun 3, 2018

cgillum commented Jun 5, 2018

TsuyoshiUshio commented Jun 5, 2018

TsuyoshiUshio commented Jun 5, 2018

cgillum commented Jun 5, 2018

TsuyoshiUshio commented Jun 5, 2018

TsuyoshiUshio commented Jun 6, 2018

cgillum commented Jun 6, 2018

TsuyoshiUshio commented Jun 6, 2018 • edited Loading

TsuyoshiUshio commented Jun 6, 2018

cgillum commented Jun 6, 2018

cgillum commented Jun 6, 2018

TsuyoshiUshio commented Jun 6, 2018

TsuyoshiUshio commented Jun 6, 2018

TsuyoshiUshio commented Jun 7, 2018

cgillum commented Jun 7, 2018

TsuyoshiUshio commented Jun 7, 2018

TsuyoshiUshio commented Jun 6, 2018 •

edited

Loading