Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new Purging History API-s #498

Merged

Conversation

gled4er
Copy link
Collaborator

@gled4er gled4er commented Nov 6, 2018

Hello @cgillum,

This is PR for integrating the changes made in Durable Task project for the History Retention feature - #17.

When you have time, please take a look.

Thank you!

@gled4er
Copy link
Collaborator Author

gled4er commented Nov 6, 2018

Hello @cgillum,

I added integration tests for the new Purge History API-s.

May I ask you to take a look when you have time and let me know what should be fixed?

Thank you!

@cgillum
Copy link
Member

cgillum commented Nov 6, 2018

Thanks! I'll take a look today.

@cgillum cgillum added the full-ci label Nov 6, 2018
@gled4er
Copy link
Collaborator Author

gled4er commented Nov 6, 2018

Thank you very much @cgillum!

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few minor fixes. This PR otherwise looks good!

@cgillum cgillum merged commit 24ed504 into Azure:dev Nov 7, 2018
@cgillum
Copy link
Member

cgillum commented Nov 7, 2018

@gled4er would you mind opening a docs PR so we can document this feature? It will need to go into the release-functions-durable-migration branch.

@gled4er
Copy link
Collaborator Author

gled4er commented Nov 7, 2018

Hello @cgillum,

Yes, I will.

Thank you for reminding me!

I think we will need documentation for the DurableActivityContextBase as well.

Thank you!

@gled4er
Copy link
Collaborator Author

gled4er commented Nov 7, 2018

Hello @cgillum,

I opened this PR for the documentation - https://github.com/MicrosoftDocs/azure-docs-pr/pull/57364

Please review it when you have time.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants