Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETW spam: FunctionFailed ETW events hardcode IsReplay to false #585

Merged
merged 1 commit into from
Jan 23, 2019
Merged

ETW spam: FunctionFailed ETW events hardcode IsReplay to false #585

merged 1 commit into from
Jan 23, 2019

Conversation

cgillum
Copy link
Member

@cgillum cgillum commented Jan 23, 2019

Fix issue where FunctionFailed ETW events have the incorrect value for the IsReplay column.

The app insights logging does the right thing, it's just the ETW logs (used internally by Microsoft) which are incorrect.

@cgillum cgillum added this to the v1.7.2 Release milestone Jan 23, 2019
@cgillum cgillum self-assigned this Jan 23, 2019
kashimiz
kashimiz approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@kashimiz kashimiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :shipit:

@cgillum cgillum merged commit f5db15e into dev Jan 23, 2019
@cgillum cgillum deleted the quick-fix branch January 23, 2019 21:37
@cgillum cgillum mentioned this pull request Jan 24, 2019
Merged
@cgillum cgillum modified the milestones: v1.7.2 Release, v1.8 Release Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashimiz kashimiz kashimiz approved these changes

@glennamanns glennamanns Awaiting requested review from glennamanns

Assignees

@cgillum cgillum

Labels
bug engineering
Projects
None yet
Milestone
v1.8 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@cgillum @kashimiz