Expose FunctionFailedException constructors for easier unit testing #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorMcMahon
commented
May 10, 2019
| /// Initializes a new instance of a <see cref="FunctionFailedException"/>. | ||
| /// </summary> | ||
| /// <param name="message">A message describing where to look for more details.</param> | ||
| public FunctionFailedException(string message) |
There was a problem hiding this comment.
Unsure if this method really should be public. It isn't currently used in our code (but the [Serializable] attribute might require the method exists). Once we expose it as public, we can't remove it without it being a breaking change.
There was a problem hiding this comment.
It's pretty common to have exception types with public constructors like this. I think it's fine to make this public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #753