Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot see function key in the portal during cold start #2861

Closed
watashiSHUN opened this issue May 17, 2018 · 1 comment
Closed

Cannot see function key in the portal during cold start #2861

watashiSHUN opened this issue May 17, 2018 · 1 comment
Assignees

Comments

@watashiSHUN
Copy link
Contributor

before we finish indexing all methods, portal will display 404 when trying to retrieve function keys. Reproducible with cold starts (ie, after fresh deployment)

Repro steps

  1. To mimic cold start, first, break the host by providing a malformed host.json
    image
  2. Go to portal, function key is missing
    image
    image

in order to retrieve function key, we don't need to wait for indexing, instead we can do everything at file system level:

private async Task<IDictionary<string, string>> GetFunctionKeys(string functionName)
{
if (!_scriptHostManager.Instance.IsFunction(functionName))
{
return null;
}
return await _secretManager.GetFunctionSecretsAsync(functionName);
}

@mathewc
Copy link
Member

mathewc commented May 17, 2018

Likely related to the work we did for #2114. Though that was done long ago.

@mathewc mathewc self-assigned this May 21, 2018
mathewc added a commit that referenced this issue May 21, 2018
@mathewc mathewc closed this as completed May 21, 2018
mathewc added a commit that referenced this issue May 21, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants