Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialization happening before EnvVars module has ran #2867

Closed
mathewc opened this issue May 18, 2018 · 0 comments
Closed

Specialization happening before EnvVars module has ran #2867

mathewc opened this issue May 18, 2018 · 0 comments
Assignees
@mathewc
Labels
bug
Milestone
Sprint 24

Comments

@mathewc
Copy link
Member

mathewc commented May 18, 2018 •
edited
Loading

It looks like we may have a race condition in specialization, where our background specialization timer triggers specialization and the host starts up BEFORE the EnvVars module has had a chance to run and apply env vars to the .NET config classes.

Plan is to have the EnvVars module notify us via a special WEBSITE_CONFIGURATION_READY environment variable that we'll gate specialization on.
@mathewc mathewc self-assigned this May 18, 2018
@paulbatum paulbatum added the bug label May 23, 2018
@paulbatum paulbatum added this to the Sprint 24 milestone May 23, 2018
@paulbatum paulbatum mentioned this issue May 30, 2018
Closed
mathewc added a commit that referenced this issue Jun 4, 2018
@mathewc
Gating host specialization on WEBSITE_CONFIGURATION_READY (#2867)
c80b9ab
@mathewc mathewc mentioned this issue Jun 4, 2018
Merged
mathewc added a commit that referenced this issue Jun 6, 2018
@mathewc
Gating host specialization on WEBSITE_CONFIGURATION_READY (#2867)
b1f77b7
mathewc added a commit that referenced this issue Jun 6, 2018
@mathewc
Gating host specialization on WEBSITE_CONFIGURATION_READY (#2867)
00d586c
mathewc added a commit that referenced this issue Jun 7, 2018
@mathewc
Gating host specialization on WEBSITE_CONFIGURATION_READY (#2867)
58d1a70
@mathewc mathewc closed this as completed Jun 13, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mathewc mathewc

Labels
bug
Projects
None yet
Milestone
Sprint 24
Development

No branches or pull requests
2 participants
@paulbatum @mathewc