Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf contract must not contain map<string, string> types #4482

Open
mhoeger opened this issue May 21, 2019 · 1 comment
Open

Protobuf contract must not contain map<string, string> types #4482

mhoeger opened this issue May 21, 2019 · 1 comment

Comments

@mhoeger
Copy link
Contributor

mhoeger commented May 21, 2019

In our protobuf contract, "map" type values should never be a native type (if it can be a null value), because it causes a Buffer overrun in JavaScript (and other languages).

Azure/azure-functions-language-worker-protobuf#21

This issue is to track a potential major version change in the protobuf contract to change all map<string, string> to map<string, NullableString> (or other nullable type

cc: @pragnagopa

@fabiocav
Copy link
Member

After talking to @mhoeger, removing the breaking flag as we can make this change in a non-breaking way

@fabiocav fabiocav removed the 3.x label Nov 20, 2019
@fabiocav fabiocav removed this from the Triaged milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants