Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"map" types to not contain empty values for node #4488

Closed
mhoeger opened this issue May 22, 2019 · 2 comments · Fixed by #4580 or #5128
Closed

"map" types to not contain empty values for node #4488

mhoeger opened this issue May 22, 2019 · 2 comments · Fixed by #4580 or #5128
Assignees

Comments

@mhoeger
Copy link
Contributor

mhoeger commented May 22, 2019

Null or empty values on protobuf map types cause buffer overruns on Node.js: Azure/azure-functions-language-worker-protobuf#21

The ultimate goal is to get rid of any map types that allow for empty values (ex: string): #4482

For now, we may need to implement host changes that filter out empty-valued pairs. This is true for http headers as well as environment variables (which will cause apps with empty-valued environment variables to fail when we implement placeholders).

cc: @pragnagopa and @fabiocav

@mhoeger mhoeger added this to the Functions Sprint 51 milestone May 29, 2019
@pragnagopa pragnagopa changed the title Special-case "map" types to not contain empty values for node "map" types to not contain empty values for node Jun 17, 2019
@pragnagopa
Copy link
Member

Note: Do not have to specialize this fix for node worker as the guidance for handling reload requests on the worker is to clear environment variables and replace

@pragnagopa
Copy link
Member

Verfied Environment.GetEnvironmentVariables does not include empty or null values.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants