-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preventing placeholder hosts from draining worker console logs #10345
Conversation
test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/SpecializationE2ETests.cs
Show resolved
Hide resolved
test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/SpecializationE2ETests.cs
Outdated
Show resolved
Hide resolved
Do we need to add an entry to release notes for this change? |
984387f
to
86e9851
Compare
As mentioned in this issue - #9360, can this be a breaking change as users will start receiving logs which they were not getting before? Some logs will be errors/warnings and can have sensitive information as part of exception details (which can be a separate issue to fix but calling it out). Do we need to inform css about this as there could be more CRIs when users see additional errors/warnings in their appInsights? |
@surgupta-msft -- good question. I wouldn't consider this a breaking change because the behavior isn't really changing today -- the problem is that during specialization, some logs disappeared. But w/o specialization, it all worked (which is why it was tough to repro initially) -- so some customers would sometimes see these logs and other times not, depending on the specialization. So i'd consider this a "fix" to make it consistently appear, even during specialization |
ffa4c96
to
709e282
Compare
Issue describing the changes in this PR
Resolves #10222 and #9360
During specialization, there can be a race to process logs being generated by the placeholder worker. If a worker writes console output during startup (say, during a file load like the issue describes), the placeholder can dequeue these and log them, which effectively means they go nowhere.
This change prevents placeholder hosts from dequeuing these messages at all, so they are ready to be consumed by the user's host starting up.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md