Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shimming legacy .NET worker JsonFunctionProvider to ensure backwards compatibility. #10411

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Shimming legacy .NET worker JsonFunctionProvider to ensure backwards compatibility. #10411

merged 1 commit into from
Aug 21, 2024

Conversation

fabiocav
Copy link
Member

@fabiocav fabiocav commented Aug 21, 2024 •
edited
Loading

Issue describing the changes in this PR

resolves #10410

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@fabiocav fabiocav requested a review from a team as a code owner August 21, 2024 03:40
@fabiocav fabiocav force-pushed the fabiocav/workermpshim branch 2 times, most recently from a132223 to c955b95 Compare August 21, 2024 03:43
@fabiocav fabiocav requested a review from kshyju August 21, 2024 03:43
kshyju
kshyju approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

brettsam
brettsam approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@brettsam brettsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is coming in hot -- but can we make sure to file an issue for a follow-up test?

@fabiocav
Copy link
Member Author

Created this issue to track: #10414

@fabiocav fabiocav merged commit 79e6068 into dev Aug 21, 2024
10 checks passed
@fabiocav fabiocav deleted the fabiocav/workermpshim branch August 21, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyju kshyju kshyju approved these changes

@brettsam brettsam brettsam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fabiocav @kshyju @brettsam