Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for identity-based connections to Diagnostic Events #10438

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

cjaliaga
Copy link
Member

@cjaliaga cjaliaga commented Aug 28, 2024

Issue describing the changes in this PR

Adds support for identity-based connections to Diagnostic Events via creating the TableServiceClient with IAzureTableStorageProvider.

resolves #9569

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Copy link
Member

@brettsam brettsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't there additional work that needed to be done to really support this in the portal? Like we could write, but the portal wouldn't be able to read, so it wouldn't work anyway? I think @soninaren mentioned it...

@cjaliaga
Copy link
Member Author

cjaliaga commented Sep 3, 2024

Wasn't there additional work that needed to be done to really support this in the portal? Like we could write, but the portal wouldn't be able to read, so it wouldn't work anyway? I think @soninaren mentioned it...

I believe the changes in Geo were already deployed if I remember correctly when we discussed this. @soninaren could you please confirm this?

Control plane changes are not yet completed.

@cjaliaga cjaliaga force-pushed the cjaliaga/identity-based-diag-events branch from f96f083 to 0c38b67 Compare September 11, 2024 16:01
@cjaliaga cjaliaga force-pushed the cjaliaga/identity-based-diag-events branch from 0c38b67 to 9f70b72 Compare October 17, 2024 22:20
release_notes.md Outdated Show resolved Hide resolved
cjaliaga and others added 4 commits October 18, 2024 16:54
@cjaliaga cjaliaga changed the title Add support for Identity-based connections to Diagnostic Events Add support for identity-based connections to Diagnostic Events Oct 18, 2024
@cjaliaga cjaliaga merged commit 5bac761 into dev Oct 18, 2024
10 checks passed
@cjaliaga cjaliaga deleted the cjaliaga/identity-based-diag-events branch October 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostic Events API should work with a Managed Identity
5 participants