-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for identity-based connections to Diagnostic Events #10438
Conversation
src/WebJobs.Script.WebHost/Diagnostics/DiagnosticEventTableStorageRepository.cs
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Diagnostics/DiagnosticEventTableStorageRepository.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't there additional work that needed to be done to really support this in the portal? Like we could write, but the portal wouldn't be able to read, so it wouldn't work anyway? I think @soninaren mentioned it...
src/WebJobs.Script.WebHost/Diagnostics/DiagnosticEventTableStorageRepository.cs
Show resolved
Hide resolved
Control plane changes are not yet completed. |
f96f083
to
0c38b67
Compare
src/WebJobs.Script.WebHost/Diagnostics/DiagnosticEventTableStorageRepository.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Diagnostics/DiagnosticEventTableStorageRepository.cs
Show resolved
Hide resolved
0c38b67
to
9f70b72
Compare
src/WebJobs.Script.WebHost/Diagnostics/DiagnosticEventRepositoryFactory.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Lilian Kasem <likasem@microsoft.com>
Issue describing the changes in this PR
Adds support for identity-based connections to Diagnostic Events via creating the
TableServiceClient
withIAzureTableStorageProvider
.resolves #9569
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md