Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip validation of FUNCTIONS_WORKER_RUNTIME with function metadata in placeholder mode #10459

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Sep 9, 2024

Skip validation of FUNCTIONS_WORKER_RUNTIME with function metadata in placeholder mode (this validation was added in #10439)

Without this change, DNI apps in placeholder mode will log the error about runtime mismatch because the "WarmUp" function's Language is "CSharp".

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR - will follow
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kshyju kshyju requested a review from a team as a code owner September 9, 2024 20:18
@kshyju kshyju changed the title Excluding WarmUp function from function metadata when validating it against FUNCTIONS_WORKER_RUNTIME value Skip validation of FUNCTIONS_WORKER_RUNTIME with function metadata in placeholder mode Sep 9, 2024
@kshyju kshyju requested a review from mathewc September 9, 2024 20:46
…led only during non placeholder mode code path. If called form placeholder mode, this method will throw now.
@kshyju kshyju requested a review from fabiocav September 9, 2024 21:34
@kshyju kshyju merged commit 48505fd into dev Sep 9, 2024
10 checks passed
@kshyju kshyju deleted the shkr/exclude_warmup_for_fwr_validation branch September 9, 2024 22:55
@kshyju
Copy link
Member Author

kshyju commented Sep 10, 2024

After consulting with the team, we decided that this change does not need to be backported to in-proc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants