Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused DocumentDD.Core package #10503

Merged
merged 10 commits into from
Oct 8, 2024
Merged

remove unused DocumentDD.Core package #10503

merged 10 commits into from
Oct 8, 2024

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Sep 30, 2024

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR -- TODO
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Removes unused packages Microsoft.Azure.DocumentDB.Core and Microsoft.Azure.Cosmos.Table. These usages have been migrated to Azure.Data.Tables.

deps.json changes:

Changed:


Removed:
- Microsoft.Azure.Cosmos.Table.dll: 1.0.8.0/1.0.8.0
- Microsoft.Azure.DocumentDB.Core.dll: 2.11.2.0/2.11.2.0
- Microsoft.OData.Core.dll: 7.6.4.0/7.6.4.10325
- Microsoft.OData.Edm.dll: 7.6.4.0/7.6.4.10325
- Microsoft.Spatial.dll: 7.6.4.0/7.6.4.10325


Added:

All removed dlls are marked private.

@jviau jviau requested a review from a team as a code owner September 30, 2024 21:13
@jviau
Copy link
Contributor Author

jviau commented Oct 2, 2024

Microsoft.Azure.DocumentDB.Core is still used extensively in test projects, and it is brought in by the 4.x Storage extension. I am working on migrating to latest storage extension and updating tests to use the new cosmos and storage SDKs. I will most likely do that in another PR.

@jviau jviau merged commit 5019ba4 into dev Oct 8, 2024
10 checks passed
@jviau jviau deleted the jviau/remove-cosmos-table branch October 8, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants