Change Blobs.CentralizedPoisonQueue default (#1106) #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettsam
approved these changes
May 4, 2018
|
I don't think we detail this really. Now all poison queue handling will be consistent for both queues and blobs. However, the user expectation is generally that it behaves like this, which is what was addressed in the original core SDK fix Azure/azure-webjobs-sdk#804. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1106. With this change, poison messages for blobs will be co-located in the storage account of the source blob container.
When I fixed this in core SDK, we couldn't take the breaking change for v1, hence this switch default.