Move Java language worker to use GenericWorkerProvider #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pragnagopa
commented
Jun 22, 2018
•
pragnagopa
commented
- Delete JavaWorkerProvider. Fixes Move Java worker providers to use generic worker provider model #2974
- Clean up unused classes. Fixes Remove IWorkerProvider.GetWorkerDirectoryPath #3031
- Removed dependency on JAVA_HOME. Fixes Remove dependency on JAVA_HOME #2920
- Fixes Multiple cli instances causing lots of cpu usage when app is idle if each instances does not define a unique node debug port. #2775
mathewc
reviewed
Jun 22, 2018
| @@ -746,9 +746,6 @@ private void InitializeWorkers() | |||
| // TODO: We still have some hard coded languages, so we need to handle them. Remove this switch once we've moved away from that. | |||
| switch (_language.ToLowerInvariant()) | |||
| { | |||
| case LanguageWorkerConstants.JavaLanguageWorkerName: | |||
There was a problem hiding this comment.
Can't this switch and TODO go away now and be a simple if(!DotNetLanguageWorker) check?
mathewc
reviewed
Jun 22, 2018
| @@ -24,5 +23,9 @@ public static class LanguageWorkerConstants | |||
| public const string WorkerDescriptionDefaultWorkerPath = "defaultWorkerPath"; | |||
| public const string WorkerDescription = "Description"; | |||
| public const string WorkerDescriptionArguments = "Arguments"; | |||
|
|
|||
| // Java | |||
| public const string AppServiceEnvJavaVersion = "zulu8.23.0.3-jdk8.0.144-win_x64"; | |||
There was a problem hiding this comment.
This hard coded version seems brittle. What if someone specifies their own java_home value pointing to their own version that is different?
There was a problem hiding this comment.
Opened #3048 to update worker.config.json to provide java version
mathewc
approved these changes
Jun 22, 2018
pragnagopa
force-pushed
the
delJavaWorkerProvider
branch
from
5ea2a10 to
7659388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.