adding exception details to FileLogger #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragnagopa
reviewed
Sep 19, 2018
| actualException = actualException.InnerException; | ||
| } | ||
|
|
||
| formattedMessage += $"{Environment.NewLine}{actualException.Message}"; |
There was a problem hiding this comment.
Full stack trace is useful. Especially for out-of-proc languages where there are compilation errors. Thoughts?
There was a problem hiding this comment.
They won't want the .NET stack, though. That'll just show the executor, invoker, etc. I suspect that whatever message an out-of-proc language logs here will include the stack for that message. I'll give it a test with node really quick.
There was a problem hiding this comment.
You are right. I just verified with your changes
Result: Failure
Exception: ReferenceError: coext is not defined
Stack: ReferenceError: coext is not defined
at module.exports (D:\pgopaGit\azure-functions-host\sample\Node\HttpTrigger\index.js:4:5)
at WorkerChannel.invocationRequest (D:\pgopaGit\azure-functions-host\src\WebJobs.Script.WebHost\bin\Debug\netcoreapp2.1\workers\node\worker-bundle.js:28843:26)
at ClientDuplexStream.WorkerChannel.eventStream.on (D:\pgopaGit\azure-functions-host\src\WebJobs.Script.WebHost\bin\Debug\netcoreapp2.1\workers\node\worker-bundle.js:28733:30)
at ClientDuplexStream.emit (events.js:182:13)
at addChunk (_stream_readable.js:283:12)
at readableAddChunk (_stream_readable.js:264:11)
at ClientDuplexStream.Readable.push (_stream_readable.js:219:10)
at Object.onReceiveMessage (D:\pgopaGit\azure-functions-host\src\WebJobs.Script.WebHost\bin\Debug\netcoreapp2.1\workers\node\worker-bundle.js:43673:19)
at InterceptingListener.module.exports.InterceptingListener.recvMessageWithContext (D:\pgopaGit\azure-functions-host\src\WebJobs.Script.WebHost\bin\Debug\netcoreapp2.1\workers\node\worker-bundle.js:43000:19)
at D:\folder\azure-functions-host\src\WebJobs.Script.WebHost\bin\Debug\netcoreapp2.1\workers\node\worker-bundle.js:43099:14
There was a problem hiding this comment.
I just wrote some nonsense in a js script and ran it. Before this change it looks like this in the file log:
2018-09-19T17:02:38.394 [Error] Executed 'Functions.HttpTrigger' (Failed, Id=74640518-a61d-4806-abcb-00676be13dca)
Now it looks like:
2018-09-19T16:59:52.268 [Error] Executed 'Functions.HttpTrigger' (Failed, Id=15486ec0-7fcd-4d41-8abb-ed75158ec90b)
Result: Failure
Exception: ReferenceError: gds is not defined
Stack: ReferenceError: gds is not defined
at module.exports (C:\git\brettsam\azure-functions-host\sample\Node\HttpTrigger\index.js:10:5)
at WorkerChannel.invocationRequest (c:\git\brettsam\azure-functions-host\src\WebJobs.Script.WebHost\bin\Debug\netcoreapp2.1\workers\node\worker-bundle.js:28843:26)
at ClientDuplexStream.WorkerChannel.eventStream.on (c:\git\brettsam\azure-functions-host\src\WebJobs.Script.WebHost\bin\Debug\netcoreapp2.1\workers\node\worker-bundle.js:28733:30)
at ClientDuplexStream.emit (events.js:182:13)
at addChunk (_stream_readable.js:283:12)
at readableAddChunk (_stream_readable.js:264:11)
at ClientDuplexStream.Readable.push (_stream_readable.js:219:10)
at Object.onReceiveMessage (c:\git\brettsam\azure-functions-host\src\WebJobs.Script.WebHost\bin\Debug\netcoreapp2.1\workers\node\worker-bundle.js:43673:19)
at InterceptingListener.module.exports.InterceptingListener.recvMessageWithContext (c:\git\brettsam\azure-functions-host\src\WebJobs.Script.WebHost\bin\Debug\netcoreapp2.1\workers\node\worker-bundle.js:43000:19)
at c:\git\brettsam\azure-functions-host\src\WebJobs.Script.WebHost\bin\Debug\netcoreapp2.1\workers\node\worker-bundle.js:43099:14
mathewc
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3481
Replacement for #3482
The FileLogger wasn't logging any exception details. This is a port of the v1 behavior from: https://github.com/Azure/azure-functions-host/blob/v1.x/src/WebJobs.Script/Diagnostics/FileTraceWriter.cs#L203-L222