Rename Source metadata property, clean up resolution logic (#351) #352
Conversation
| // First see if there is an explicit primary file indicated | ||
| // in config. If so use that. | ||
| string functionPrimary = null; | ||
| string scriptFileName = (string)functionConfig["scriptFile"]; |
There was a problem hiding this comment.
This property used to be called "source". We're renaming this to "scriptFile". It's an undocumented property at this point, so we'll be safe in making the breaking change.
There was a problem hiding this comment.
"scriptFile", not "sourceFile" :)
| scriptFileName = Path.GetFileNameWithoutExtension(scriptFileName); | ||
|
|
||
| functionPrimary = functionFiles.FirstOrDefault(p => | ||
| string.Compare(Path.GetFileNameWithoutExtension(p), scriptFileName, StringComparison.OrdinalIgnoreCase) == 0); |
There was a problem hiding this comment.
This extension logic doesn't feel quite right. Say the file is named foo.bar.js. It sounds like scriptFile can be either set to foo.bar or foo.bar.js? But if it's just foo.bar, GetFileNameWithoutExtension will end up with just foo. Also, you could end up finding a file that has the same name without extension, but a mismatched extension.
There was a problem hiding this comment.
Well, to avoid all of this, I can just make source file have to be the entire file name. Perhaps that is cleaner and easier to explain.
There was a problem hiding this comment.
Yes, that's probably best. Allowing either form is just asking for trouble, with too little gain to be worthwhile :)
Addresses bug# #351
Also improving the error message we give when we can't determine the primary script file. As David indicated in the bug, Kudu is using this exact same logic. The plan is to copy this updated function to Kudu as well, and release these updates together.
@davidebbo @ahmelsayed