fix the addresss of the BuildService #7367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragnagopa
reviewed
May 12, 2021
| url = $"http://{ManagedKubernetesBuildServiceName}.{ManagedKubernetesBuildServiceNamespace}.svc.cluster.local:{ManagedKubernetesBuildServicePort}/operations/settriggers"; | ||
| var buildServiceHostname = | ||
| _environment.GetEnvironmentVariable(EnvironmentSettingNames.BuildServiceHostname); | ||
|
|
There was a problem hiding this comment.
Move this to environment extensions and add tests
There was a problem hiding this comment.
Done.
Could you have a look? @pragnagopa
|
Please link the issue in the host repo |
…onmnetSetttingNames
pragnagopa
reviewed
May 12, 2021
| @@ -149,6 +149,18 @@ public void IsPersistentStorageAvailable_IsLinuxWithStorage_ReturnsTrue() | |||
| Assert.True(environment.IsPersistentFileSystemAvailable()); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void IsBuildServiceHostname_Returns_ConfiguredValue() | |||
| { | |||
There was a problem hiding this comment.
nit: use [Theory] - use inline data
There was a problem hiding this comment.
Done. Looks good? or modify it more?
pragnagopa
previously approved these changes
May 12, 2021
ahmelsayed
previously approved these changes
May 12, 2021
|
@TsuyoshiUshio -please take a look at the failed unit tests. Ok to Ignore JIT trace test |
|
@fabiocav - Windows JitTrace file test is failing. Ok to skip this test for Linux hotfix? As part of next release we can enable this test and regenerate JITTrace ? |
|
The second PR doesn't cause Jit test fails. Close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Kubernetes Environment Build Service URL.
Keep the current behavior by default.
Also fix the wrong '/operations/settriggers' It should be '/api/operations/settriggers'
CC: @pragnagopa
Fix
Resolves #7360
https://github.com/microsoft/k4apps/issues/556
Pull request checklist