Disposing of DependencyTrackingTelemetryModule before host is disposed #7448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #7446. /cc @cijothomas |
|
Test failed as expected: https://azfunc.visualstudio.com/Azure%20Functions/_build/results?buildId=18651&view=ms.vss-test-web.build-test-results-tab&runId=1096486&resultId=100278&paneView=debug. Fix is now uncommented. |
cijothomas
previously approved these changes
Jun 10, 2021
fabiocav
previously approved these changes
Jun 10, 2021
fabiocav
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note -- I originally made a commit has the fix commented out so I can verify it fails in CI. It failed 100% of the time locally.
This fixes the error:
Tactical change to fix a race condition during disposal of the
DependencyTrackingTelemetryModule. It must be disposed beforeTelemetryConfiguration. This change explicitly disposes it before disposing the host.This issue is fixed in ApplicationInsights here -- microsoft/ApplicationInsights-dotnet#2294 -- but this won't be released until 2.0.18. Once we pull that version, we can delete this fix (but keep the test).