Worker Indexing Changes #7606
Merged
Worker Indexing Changes #7606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ables/worker config variables to test cases. Add null checks to _workerRuntime and workerConfig code sections.
…integration tests
… logic in FunctionMetadataProviderFactory
…sage names Fixed invocation troubles for worker indexed functions --> was just missing a few lines from ScriptHost
…ots of tests Replaced dispatcher.InitializeAsync(null) with new List<FunctionMetadata> as the parameter instead of null Renamed FunctionMetadataProviderTests as HostFunctionMetadataProviderTests
… provider factory, updated the tests
…tEnv Added new RawFunctionMetadata type Moved Binding parsing logic into WorkerFunctionMetadataProvider
…nd ValidateMetadata() validation logic Added simple HttpFunctionInvocationDispatcher implementation for worker indexing functions Cleaned ScriptHost worker indexing logic and WorkerFunctionMetadataProvider logic
Add detailed binding validation logic to WorkerFunctionMetadataProvider Add detailed comments to HTTP dispatcher
Throw NotSupportedException in HttpFunctionInvocationDispatcher for worker indexing-related functions
satvu
reviewed
Oct 14, 2021
* Moving ValidateBinding to Utility * Moving ValidateFunction to utility and modifying tests to remove dupliation * Fixing PR comments * Removing proxy from message
…om/Azure/azure-functions-host into t-anjanan/workingSteinChanges-fork
19 tasks
|
@vrdmr we're getting close to merging this, but I wanted to see if you have any additional feedback you want to provide. |
alrod
previously requested changes
Nov 3, 2021
src/WebJobs.Script.Grpc/azure-functions-language-worker-protobuf/src/proto/FunctionRpc.proto
Show resolved
Hide resolved
| var workerConfigs = _languageWorkerOptions.Value.WorkerConfigs; | ||
|
|
||
| IFunctionMetadataProvider metadataProvider = Utility.CanWorkerIndex(workerConfigs, _environment) | ||
| ? new WorkerFunctionMetadataProvider(_loggerFactory.CreateLogger<WorkerFunctionMetadataProvider>(), dispatcher) |
There was a problem hiding this comment.
We can add something like IFunctionMetadataProviderFactory which will create appropriate IFunctionMetadataProvider depending on the config. IFunctionMetadataProviderFactory is added to FunctionMetadataManager using DI.
To get a dispatcher use FunctionInvocationDispatcherFactory
src/WebJobs.Script.Grpc/azure-functions-language-worker-protobuf/src/proto/FunctionRpc.proto
Show resolved
Hide resolved
src/WebJobs.Script/Workers/Rpc/FunctionRegistration/RpcFunctionInvocationDispatcher.cs
Outdated
Show resolved
Hide resolved
...bJobs.Script.Tests.Integration/ApplicationInsights/ApplicationInsightsCSharpEndToEndTests.cs
Show resolved
Hide resolved
|
Can you please rebase on latest dev |
yes, last done on 11/8. Doing this regularly. |
soninaren
previously approved these changes
Nov 8, 2021
soninaren
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
#7496
Wiki
https://github.com/Azure/azure-functions-host/wiki/Worker-Indexing-Changes
Design doc - Here
Pull request checklist
release_notes.mdAdditional information
Additional PR information