HostID Collision detection #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewc
commented
Sep 20, 2021
| public class HostIdValidator | ||
| { | ||
| public const string BlobPathFormat = "ids/usage/{0}"; | ||
| private const LogLevel DefaultLevel = LogLevel.Warning; |
There was a problem hiding this comment.
When this is merged to the v4 branch, we simply have to update this to default Error level.
mathewc
commented
Sep 20, 2021
mathewc
force-pushed
the
host-id-check
branch
3 times, most recently
from
c36c339 to
17773ba
Compare
paulbatum
reviewed
Sep 23, 2021
fabiocav
reviewed
Sep 24, 2021
| // Schedule the validation to run asynchronously after a delay. This delay ensures | ||
| // we're not impacting coldstart, and also gives time for the primary host to be | ||
| // identified. | ||
| Utility.ExecuteAfterDelay(() => Task.Run(() => ValidateHostIdUsageAsync(hostId)), TimeSpan.FromSeconds(validationDelaySeconds)); |
There was a problem hiding this comment.
Is there a reason for the Task.Run here?
There was a problem hiding this comment.
I need to kick off an asynchronous background task that isn't awaited. I could remove the Task.Run, and add inline #pragmas to ignore the unawaited task warnings, but this seems preferable.
There was a problem hiding this comment.
With the language version we're using, we should be able to use a discard, right?
brettsam
reviewed
Sep 24, 2021
mathewc
force-pushed
the
host-id-check
branch
from
17773ba to
45d0e5c
Compare
mathewc
force-pushed
the
host-id-check
branch
from
45d0e5c to
e72dae2
Compare
brettsam
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logic to detect host ID collisions in shared storage accounts. In Functions v3 this will log a warning when detected, and in v4 it will be an error.
Breaking change proposal for v4: Azure/Azure-Functions#2049