Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for index.cjs files #8205

Merged
merged 9 commits into from
Mar 8, 2022
Merged

Add support for index.cjs files #8205

merged 9 commits into from
Mar 8, 2022

Conversation

hossam-nasr
Copy link
Contributor

@hossam-nasr hossam-nasr commented Mar 7, 2022 •
edited
Loading

Auto-detects "index.cjs" files as primary for node functions. Implementes #8213

Issues describing the changes in this PR

This is related to this issue in the node worker, which includes adding support for ".cjs" files.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR
  • I have added all required tests (Unit tests, E2E tests)

@hossam-nasr hossam-nasr mentioned this pull request Mar 7, 2022
Closed
7 tasks
ejizba
ejizba reviewed Mar 8, 2022
View reviewed changes
release_notes.md Outdated Show resolved Hide resolved
@hossam-nasr hossam-nasr mentioned this pull request Mar 8, 2022
Closed
@hossam-nasr hossam-nasr merged commit cc18866 into dev Mar 8, 2022
@hossam-nasr hossam-nasr deleted the hossamnasr/cjsSupport branch March 8, 2022 22:50
Francisco-Gamino
Francisco-Gamino approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satvu satvu satvu approved these changes

@Francisco-Gamino Francisco-Gamino Francisco-Gamino approved these changes

@ejizba ejizba ejizba approved these changes

@liliankasem liliankasem liliankasem approved these changes

@fabiocav fabiocav Awaiting requested review from fabiocav

@alrod alrod Awaiting requested review from alrod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hossam-nasr @liliankasem @ejizba @Francisco-Gamino @satvu