bumping nuget project model reference #9356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/WebJobs.Script.Tests/Microsoft.Azure.WebJobs.Script.WebHost.deps.json
Show resolved
Hide resolved
surgupta-msft
approved these changes
Jun 28, 2023
brettsam
force-pushed
the
brettsam/nuget_bump
branch
from
eee0558 to
d91a285
Compare
liliankasem
approved these changes
Jun 29, 2023
brettsam
commented
Jun 29, 2023
| @@ -4608,6 +4624,13 @@ | |||
| "path": "system.objectmodel/4.0.12", | |||
| "hashPath": "system.objectmodel.4.0.12.nupkg.sha512" | |||
| }, | |||
| "System.Private.Uri/4.3.2": { | |||
There was a problem hiding this comment.
System.Private.Uri is already listed as minorMatchOrLower... but it's not clear what version we were previously referencing. It appears that we weren't referencing?
@fabiocav -- any ideas here? Should we move this to private if we weren't referencing it previously?
There was a problem hiding this comment.
Followed up with @brettsam offline. This is fine as-is, as it's already a dependency of the host (and a framework reference), but now being overridden with the package reference.
fabiocav
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.