Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Authentication Endpoint to MSI Properties #9374

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

annzho
Copy link
Contributor

@annzho annzho commented Jul 6, 2023

Issue describing the changes in this PR

Including Authentication Endpoint in MSI Properties as bug fix for this work item.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@annzho annzho requested a review from a team as a code owner July 6, 2023 21:10
@annzho annzho marked this pull request as draft July 6, 2023 21:11
@annzho annzho requested a review from karshinlin July 6, 2023 21:11
@annzho annzho marked this pull request as ready for review July 11, 2023 21:15
@annzho annzho requested review from pragnagopa, yojagad and balag0 July 11, 2023 21:15
@annzho
Copy link
Contributor Author

annzho commented Jul 13, 2023

Hi @pragnagopa, could you take a look at this PR? It's a small change with accompanying tests, just adding the AuthenticationEndpoint property to the ManagedServiceIdentity class

@annzho
Copy link
Contributor Author

annzho commented Jul 17, 2023

Hi @pragnagopa, just wanted to follow up - could you take a look at this?

@annzho annzho merged commit 08d385e into dev Aug 2, 2023
@annzho annzho deleted the anniezhou/use-authentication-endpoint branch August 2, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants