Improving error handling in SecretManager #9429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
reviewed
Jul 31, 2023
src/WebJobs.Script.WebHost/Security/KeyManagement/SecretManager.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Jul 31, 2023
src/WebJobs.Script.WebHost/Security/KeyManagement/SecretManager.cs
Outdated
Show resolved
Hide resolved
…r.cs Co-authored-by: Lilian Kasem <likasem@microsoft.com>
mathewc
reviewed
Aug 1, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| // no secrets exist for this function so generate them | ||
| string message = string.Format(Resources.TraceFunctionSecretGeneration, functionName); | ||
| _logger.LogDebug(message); |
Check failure
Code scanning / CodeQL
Log entries created from user input
brettsam
reviewed
Aug 3, 2023
src/WebJobs.Script.WebHost/Security/KeyManagement/SecretManager.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Security/KeyManagement/SecretManager.cs
Outdated
Show resolved
Hide resolved
…nto aibhandari/secret-manager-conflict
brettsam
reviewed
Aug 4, 2023
src/WebJobs.Script.WebHost/Security/KeyManagement/SecretManager.cs
Outdated
Show resolved
Hide resolved
brettsam
approved these changes
Aug 4, 2023
satvu
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
This PR improves error handling in the Secret manager so that if there's a race condition (ie multiple secret repositories are created, each try to create their own version of a secret, and whichever one actually creates it first succeeds and the rest error out). If an error happens with
WriteAsync, we simply callLoadSecretsAsyncfirst before failing and throwing an exception to make sure the issue is not a race conditionresolves #8731
Pull request checklist
release_notes.mdAdditional information
Additional PR information