Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes around fields in KubernetesEventGenerator #9475

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

AmeyaRele
Copy link
Contributor

@AmeyaRele AmeyaRele commented Aug 18, 2023

Issue describing the changes in this PR

Removes double quotes around the fields using NormalizeString.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@AmeyaRele AmeyaRele requested a review from a team as a code owner August 18, 2023 08:24
@AmeyaRele AmeyaRele changed the title Remove quotes around columns in KubernetesEventGenerator Remove quotes around log rows in KubernetesEventGenerator Aug 18, 2023
@AmeyaRele AmeyaRele changed the title Remove quotes around log rows in KubernetesEventGenerator Remove quotes around log values in KubernetesEventGenerator Aug 18, 2023
@AmeyaRele AmeyaRele changed the title Remove quotes around log values in KubernetesEventGenerator Remove quotes around fields in KubernetesEventGenerator Aug 18, 2023
@mathewc
Copy link
Member

mathewc commented Aug 21, 2023

No details given on what problem we're trying to solve with this PR. Also wondering why this is only needed for the Kubernetes logger - this same Normalize method is used by the other Linux other loggers as well w/o this special trim operation.

@AmeyaRele
Copy link
Contributor Author

AmeyaRele commented Aug 22, 2023

Tagged @mathewc on the related thread on teams.
Basically we are seeing these double quotes in the logs for Functions on ACA. In other SKUs these double quotes are used as a delimiter. However as KubernetesEventGenerator produces logs in json format, and we are directly using a json parser on fluent bit to parse these logs, that does not seem to remove these extra double quotes

@AmeyaRele AmeyaRele merged commit 88b610c into dev Sep 4, 2023
@AmeyaRele AmeyaRele deleted the ameyarele/eventgenchange branch September 4, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants