Update WebJobsScriptHostService to remove hardcoded sleep during shut down

[liliankasem]

Issue describing the changes in this PR

resolves #8681

Pull request checklist

• My changes do not require documentation changes
  • Otherwise: Documentation issue linked to PR
• My changes should not be added to the release notes for the next release
  • Otherwise: I've added my notes to release_notes.md
• My changes do not need to be backported to a previous version
  • Otherwise: Backport tracked by issue/PR #issue_or_pr
• My changes do not require diagnostic events changes
  • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
• I have added all required tests (Unit tests, E2E tests)

Additional information

Antares does not rely on the flag FUNCTIONS_ENABLE_DRAIN_ON_APP_STOPPING – so we can safely assume that this code path is only used in LIMA. Speaking to the LIMA team we learnt that the time for sleep is inconsequential for the LIMA scenario and therefore should be safe to remove.

[mathewc]

Are we backporting this? I see you said no above.

azure-functions-host/src/WebJobs.Script.WebHost/WebJobsScriptHostService.cs

Line 796 in 3866b07

// Workaround until https://github.com/Azure/azure-functions-host/issues/7188 is addressed.

[fabiocav]

@mathewc we're no longer backporting any changes. Do you think this change should be considered?

[mathewc]

I agree that we don't need to do a special v3 release for this, but if we end up needing to do one in the future for other reasons, it'd be good to have this change in there as well I think.

[liliankasem]

I agree that we don't need to do a special v3 release for this, but if we end up needing to do one in the future for other reasons, it'd be good to have this change in there as well I think.

That's fair, there's no harm in backporting any who

[liliankasem]

/backport to v3.x

[github-actions]

Started backporting to v3.x: https://github.com/Azure/azure-functions-host/actions/runs/6125295823

[github-actions]

@liliankasem backporting to v3.x failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Update WebJobsScriptHostService.cs
Applying: Update release_notes.md
Using index info to reconstruct a base tree...
M	release_notes.md
Falling back to patching base and 3-way merge...
Auto-merging release_notes.md
CONFLICT (content): Merge conflict in release_notes.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Update release_notes.md
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[liliankasem]

Backport here: #9521