Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable worker indexing by default #9574

Merged
merged 6 commits into from
Nov 18, 2023
Merged

Enable worker indexing by default #9574

merged 6 commits into from
Nov 18, 2023

Conversation

soninaren
Copy link
Member

@soninaren soninaren commented Sep 27, 2023 •
edited
Loading

Update the worker indexing enablement logic to the following:

  1. Worker indexing is disabled for Logic apps]
  2. EnableWorkerIndexing set through AzureWebjobsFeatuerFlag always take precdence
  3. If AzureWebjobsFeatuerFlag is not set and WORKER_INDEXING_DISABLED contains the customers app name worker indexing is then disabled for that customer only

resolves #9536

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@soninaren soninaren requested a review from a team as a code owner September 27, 2023 19:15
@liliankasem liliankasem changed the title Nasoni/default indexing Enable worker indexing by default Sep 27, 2023
liliankasem
liliankasem reviewed Sep 27, 2023
View reviewed changes
release_notes.md Outdated Show resolved Hide resolved
surgupta-msft
surgupta-msft reviewed Sep 28, 2023
View reviewed changes
src/WebJobs.Script/Utility.cs Outdated Show resolved Hide resolved
src/WebJobs.Script/Utility.cs Show resolved Hide resolved
@soninaren soninaren force-pushed the nasoni/defaultIndexing branch 2 times, most recently from b9ac992 to 6dcb1ca Compare October 11, 2023 14:00
@soninaren soninaren force-pushed the nasoni/defaultIndexing branch from 2ac62b4 to 7e293dc Compare November 1, 2023 23:20
kshyju
kshyju reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still failing?

src/WebJobs.Script/Utility.cs Show resolved Hide resolved
@soninaren soninaren force-pushed the nasoni/defaultIndexing branch 2 times, most recently from d2eeb3f to 180491e Compare November 17, 2023 22:29
@soninaren soninaren force-pushed the nasoni/defaultIndexing branch from 180491e to 2d5d3f6 Compare November 18, 2023 00:02
@soninaren soninaren merged commit a0b23d3 into dev Nov 18, 2023
9 checks passed
@soninaren soninaren deleted the nasoni/defaultIndexing branch November 18, 2023 02:15
@brettsam
Copy link
Member

brettsam commented Nov 27, 2023 •
edited
Loading

Fixes #9669.

Specifically with the change here to no longer do TryRemove() -- https://github.com/Azure/azure-functions-host/pull/9574/files#diff-b482fc634ed2b2979781211daa2f08a9196fe4a51a9c76972a2dea16717df99fL231

@brettsam brettsam mentioned this pull request Nov 27, 2023
Closed
This was referenced Aug 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyju kshyju kshyju left review comments

@brettsam brettsam Awaiting requested review from brettsam

@fabiocav fabiocav Awaiting requested review from fabiocav

@liliankasem liliankasem Awaiting requested review from liliankasem

@surgupta-msft surgupta-msft Awaiting requested review from surgupta-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable worker indexing by default.
5 participants
@soninaren @brettsam @kshyju @liliankasem @surgupta-msft