Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix4.28.3 - remove condition exception/fixing race condition #9742

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Hotfix4.28.3 - remove condition exception/fixing race condition #9742

merged 3 commits into from
Dec 13, 2023

Conversation

v-imohammad
Copy link
Contributor

@v-imohammad v-imohammad commented Dec 13, 2023 •
edited by fabiocav
Loading

Issue describing the changes in this PR

This PR brings the changes made in #9738 and #9739 into the 4.28.3 hotfix.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@v-imohammad v-imohammad requested a review from a team as a code owner December 13, 2023 21:24
VpOfEngineering
VpOfEngineering suggested changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@VpOfEngineering VpOfEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe one of the steps is to change the common.props release version. Can you please do so? And please update the PR description - thanks!

@v-imohammad v-imohammad changed the title Hotfix4.28.2 Hotfix4.28.3 Dec 13, 2023
@fabiocav
Copy link
Member

@v-imohammad as requested by @VpOfEngineering , can you please update the PR description with the details and go through the checklist?

@v-imohammad v-imohammad changed the title Hotfix4.28.3 Hotfix4.28.3 - remove condition exception/fixing race condition Dec 13, 2023
@v-imohammad v-imohammad merged commit 359eb50 into release/4.x-hotfix Dec 13, 2023
6 checks passed
@v-imohammad v-imohammad deleted the hotfix4.28.2 branch December 13, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocav fabiocav fabiocav approved these changes

@brettsam brettsam brettsam approved these changes

@VpOfEngineering VpOfEngineering Awaiting requested review from VpOfEngineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-imohammad @fabiocav @brettsam @VpOfEngineering @mathewc