Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with HTTP request forwarding and adding retries #9949

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

fabiocav
Copy link
Member

@fabiocav fabiocav commented Mar 26, 2024

Resolves #9954

This PR fixes a few issues identified while investigating support cases and internal reports.

  • Addresses a potential race with worker initialization, primarily handled by a retry
  • Ensures the forwarding task is evaluated in failed execution scenarios
  • Ensures any exceptions captured by the forwarder are thrown/logged, so we have information about underlying failures
  • Refactored code in the invocation handling to simplify the method
  • A few performance optimizations in that hot path

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@fabiocav fabiocav requested a review from a team as a code owner March 26, 2024 00:45
@fabiocav fabiocav force-pushed the fabiocav/http-sync-retry branch 2 times, most recently from b004eb4 to 6a350cc Compare March 26, 2024 16:22
Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release notes update missing.

@fabiocav fabiocav merged commit 330130b into dev Mar 28, 2024
9 checks passed
@fabiocav fabiocav deleted the fabiocav/http-sync-retry branch March 28, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP proxying fails at initialization if worker endpoint is not yet ready
3 participants