Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove work lib logics #443

Closed
wants to merge 1 commit into from
Closed

remove work lib logics #443

wants to merge 1 commit into from

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Aug 24, 2021

Remove the logics for customer opt-in. Right now, customer is required to provide their own lib directory.
Question to be clarified: one unit test failed due to the code change. Since this unit test didn't provide a it's lib directory.
Proposed solution: copy the lib folder to target folder when build the package. This lib folder will work as a customer lib directory for unit tests.

@TsuyoshiUshio
Copy link
Contributor

Hi @kaibocai
I did some research. The spec will be like this.

To give the context, when we are Java8, we switched the order of the read 3rd party library and azure functions library by the environment variable FUNCTIONS_WORKER_JAVA_LOAD_APP_LIBS. #381

It is the only feature for Java8. So that we don't need it for V4.
If the customer have a lib directory, load the customer libraries. If they don't have it, it's ok.
https://docs.microsoft.com/en-us/azure/azure-functions/functions-reference-java?tabs=bash%2Cconsumption#third-party-libraries

So that you need to keep this logic.
https://github.com/Azure/azure-functions-java-worker/pull/443/files#diff-8ba6922619e77013eed80700fc98dcbe05895acc55b1d705533074889f5528a0L92-L95

@kaibocai
Copy link
Member Author

Hi @kaibocai
I did some research. The spec will be like this.

To give the context, when we are Java8, we switched the order of the read 3rd party library and azure functions library by the environment variable FUNCTIONS_WORKER_JAVA_LOAD_APP_LIBS. #381

It is the only feature for Java8. So that we don't need it for V4.
If the customer have a lib directory, load the customer libraries. If they don't have it, it's ok.
https://docs.microsoft.com/en-us/azure/azure-functions/functions-reference-java?tabs=bash%2Cconsumption#third-party-libraries

So that you need to keep this logic.
https://github.com/Azure/azure-functions-java-worker/pull/443/files#diff-8ba6922619e77013eed80700fc98dcbe05895acc55b1d705533074889f5528a0L92-L95

Make sense. Thank you!

@kaibocai kaibocai closed this Aug 24, 2021
@kaibocai kaibocai deleted the v4_kc_worklib_removal branch August 24, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants