Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance rpc exception in app inisght sdk #616

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Aug 16, 2022

Issue describing the changes in this PR

resolves [#issue_for_this_pr](Azure/azure-functions-host#4296)
More info can be found: Azure/azure-functions-language-worker-protobuf#70

Currently all exception happen in cx code are warped into RPCException and showing up in app insight as
image
this causing cx to believe the exception comes from functions planform and confuse them. Enhance the user exception by specify if it's a exception comes from user function and what type of exception it is.

worker side
image

host side
image

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kaibocai kaibocai requested a review from trask August 16, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant