Upgrading confluent package to 2.4.0(#504)

* Upgrading confluent package * nit changes for the build to succeed.
Azure · Jul 25, 2024 · 4562f14 · 4562f14
1 parent d0f4378
commit 4562f14
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 26 deletions.
diff --git a/samples/dotnet/KafkaFunctionSample/KafkaFunctionSample.csproj b/samples/dotnet/KafkaFunctionSample/KafkaFunctionSample.csproj
@@ -5,9 +5,7 @@
     <AzureFunctionsVersion>v3</AzureFunctionsVersion>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Confluent.Kafka" Version="1.9.0" />
     <PackageReference Include="Microsoft.NET.Sdk.Functions" Version="3.0.7" />
-    <PackageReference Include="Confluent.SchemaRegistry.Serdes.Protobuf" Version="1.9.0" />
   </ItemGroup>
   <ItemGroup>
     <None Update="host.json">

diff --git a/samples/dotnet/SampleHost/SampleHost.csproj b/samples/dotnet/SampleHost/SampleHost.csproj
@@ -8,9 +8,6 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Azure.WebJobs.Logging" Version="3.0.5" />
-    <PackageReference Include="Confluent.Kafka" Version="1.9.0" />
-    <PackageReference Include="Confluent.SchemaRegistry" Version="1.9.0" />
-    <PackageReference Include="Confluent.SchemaRegistry.Serdes.Protobuf" Version="1.9.0" />
     <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Storage" Version="3.0.4" />
     <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="2.2.0" />
   </ItemGroup>

diff --git a/src/Microsoft.Azure.WebJobs.Extensions.Kafka/Config/AzureFunctionsFileHelper.cs b/src/Microsoft.Azure.WebJobs.Extensions.Kafka/Config/AzureFunctionsFileHelper.cs
@@ -9,7 +9,7 @@
 namespace Microsoft.Azure.WebJobs.Extensions.Kafka
 {
     /// <summary>
-    /// Helper class for file related operations in functions running in Azure
+    /// Helper class for file related operations in functions running in Azure.
     /// </summary>
     internal static class AzureFunctionsFileHelper
     {
@@ -34,7 +34,7 @@ internal static class AzureFunctionsFileHelper
 
         /// <summary>
         /// Indicates if the current excecution environment is either a function hosted in Azure or 
-        /// a function hosted in a container
+        /// a function hosted in a container.
         /// </summary>
         internal static bool IsRunningAsFunctionInAzureOrContainer()
         {
@@ -47,7 +47,7 @@ internal static bool IsRunningAsFunctionInAzureOrContainer()
         /// Gets the function base folder when running as Azure Function App or as a container
         /// When running in Azure Function App default is D:\home\site\wwwroot
         /// When running in Azure Function container default is /home/site/wwwroot
-        /// If not running in Azure or container returns null
+        /// If not running in Azure or container returns null.
         /// </summary>
         internal static string GetFunctionBaseFolder()
         {
@@ -83,7 +83,7 @@ internal static string GetFunctionBaseFolder()
         /// <summary>
         /// Initializes the librdkafka library from a specific place
         /// This address the problem that running Functions in Azure won't have the current directory where the function code is.
-        /// This way we need to specifically choose the location where librdkafka is located
+        /// This way we need to specifically choose the location where librdkafka is located.
         /// </summary>
         internal static void InitializeLibrdKafka(ILogger logger)
         {
@@ -164,11 +164,11 @@ internal static void InitializeLibrdKafka(ILogger logger)
         }
 
         /// <summary>
-        /// Ensure file exists, checking for azure function base folder if not found in provided path
+        /// Ensure file exists, checking for azure function base folder if not found in provided path.
         /// </summary>
-        /// <param name="filePath">The file path to validate</param>
-        /// <param name="resultFilePath">The valid file path</param>
-        /// <returns>True if the file returned by <paramref name="resultFilePath"/> exists, otherwise false</returns>
+        /// <param name="filePath">The file path to validate.</param>
+        /// <param name="resultFilePath">The valid file path.</param>
+        /// <returns>True if the file returned by <paramref name="resultFilePath"/> exists, otherwise false.</returns>
         internal static bool TryGetValidFilePath(string filePath, out string resultFilePath)
         {
             resultFilePath = null;

diff --git a/src/Microsoft.Azure.WebJobs.Extensions.Kafka/Listeners/KafkaListener.cs b/src/Microsoft.Azure.WebJobs.Extensions.Kafka/Listeners/KafkaListener.cs
@@ -17,7 +17,7 @@ namespace Microsoft.Azure.WebJobs.Extensions.Kafka
 {
     /// <summary>
     /// Kafka listener.
-    /// Connects a Kafka trigger function with a Kafka Consumer
+    /// Connects a Kafka trigger function with a Kafka Consumer.
     /// </summary>
     internal class KafkaListener<TKey, TValue> : IListener, IScaleMonitorProvider, ITargetScalerProvider
     {
@@ -52,7 +52,7 @@ internal class KafkaListener<TKey, TValue> : IListener, IScaleMonitorProvider, I
         protected Lazy<KafkaTargetScaler<TKey, TValue>> targetScaler;
 
         /// <summary>
-        /// Gets the value deserializer
+        /// Gets the value deserializer.
         /// </summary>
         /// <value>The value deserializer.</value>
         internal IDeserializer<TValue> ValueDeserializer { get; }
@@ -157,7 +157,7 @@ public Task StartAsync(CancellationToken cancellationToken)
         }
 
         /// <summary>
-        /// Creates the ConsumerBuilder. Overriding in unit tests
+        /// Creates the ConsumerBuilder. Overriding in unit tests.
         /// </summary>
         protected virtual ConsumerBuilder<TKey, TValue> CreateConsumerBuilder(ConsumerConfig config) => new ConsumerBuilder<TKey, TValue>(config);
 

diff --git a/src/Microsoft.Azure.WebJobs.Extensions.Kafka/Microsoft.Azure.WebJobs.Extensions.Kafka.csproj b/src/Microsoft.Azure.WebJobs.Extensions.Kafka/Microsoft.Azure.WebJobs.Extensions.Kafka.csproj
@@ -34,12 +34,12 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
-    <PackageReference Include="Confluent.Kafka" Version="1.9.0" />
-    <PackageReference Include="Confluent.SchemaRegistry" Version="1.9.0" />
-    <PackageReference Include="Confluent.SchemaRegistry.Serdes.Avro" Version="1.9.0" />
-    <PackageReference Include="Confluent.SchemaRegistry.Serdes.Protobuf" Version="1.9.0" />
-    <PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.37" />
-    <PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta004">
+    <PackageReference Include="Confluent.Kafka" Version="2.4.0" />
+    <PackageReference Include="Confluent.SchemaRegistry" Version="2.4.0" />
+    <PackageReference Include="Confluent.SchemaRegistry.Serdes.Avro" Version="2.4.0" />
+    <PackageReference Include="Confluent.SchemaRegistry.Serdes.Protobuf" Version="2.4.0" />
+    <PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.39" />
+    <PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     <PackageReference Include="System.Threading.Channels" Version="4.5.0" />

diff --git a/...ensions.Kafka.EndToEndTests/Microsoft.Azure.WebJobs.Extensions.Kafka.EndToEndTests.csproj b/...ensions.Kafka.EndToEndTests/Microsoft.Azure.WebJobs.Extensions.Kafka.EndToEndTests.csproj
@@ -30,10 +30,10 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
     <PackageReference Include="Microsoft.Azure.WebJobs.Logging" Version="4.0.3" />
-    <PackageReference Include="Confluent.Kafka" Version="1.9.0" />
-    <PackageReference Include="Confluent.SchemaRegistry" Version="1.9.0" />
-    <PackageReference Include="Confluent.SchemaRegistry.Serdes.Avro" Version="1.9.0" />
-    <PackageReference Include="Confluent.SchemaRegistry.Serdes.Protobuf" Version="1.9.0" />
+    <PackageReference Include="Confluent.Kafka" Version="2.4.0" />
+    <PackageReference Include="Confluent.SchemaRegistry" Version="2.4.0" />
+    <PackageReference Include="Confluent.SchemaRegistry.Serdes.Avro" Version="2.4.0" />
+    <PackageReference Include="Confluent.SchemaRegistry.Serdes.Protobuf" Version="2.4.0" />
     <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Storage" Version="5.3.0" />
   </ItemGroup>