Make error message even better for missing binding (#213)

Azure · Jan 30, 2024 · a94e78c · a94e78c
1 parent 6e68b78
commit a94e78c
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 1 deletion.
diff --git a/src/InvocationModel.ts b/src/InvocationModel.ts
@@ -20,6 +20,7 @@ import { fromRpcTypedData } from './converters/fromRpcTypedData';
 import { toCamelCaseValue } from './converters/toCamelCase';
 import { toRpcHttp } from './converters/toRpcHttp';
 import { toRpcTypedData } from './converters/toRpcTypedData';
+import { AzFuncSystemError } from './errors';
 import { InvocationContext } from './InvocationContext';
 import { isHttpTrigger, isTimerTrigger, isTrigger } from './utils/isTrigger';
 import { isDefined, nonNullProp, nonNullValue } from './utils/nonNull';
@@ -62,7 +63,15 @@ export class InvocationModel implements coreTypes.InvocationModel {
                 const bindingName = nonNullProp(binding, 'name');
                 let input: unknown = fromRpcTypedData(binding.data);
 
-                const bindingType = nonNullProp(this.#bindings, bindingName).type;
+                const rpcBinding = this.#bindings[bindingName];
+                if (!rpcBinding) {
+                    throw new AzFuncSystemError(
+                        `Failed to find binding "${bindingName}" in bindings "${Object.keys(this.#bindings).join(
+                            ', '
+                        )}".`
+                    );
+                }
+                const bindingType = rpcBinding.type;
                 if (isTimerTrigger(bindingType)) {
                     input = toCamelCaseValue(input);
                 }

diff --git a/test/InvocationModel.test.ts b/test/InvocationModel.test.ts
@@ -79,5 +79,36 @@ describe('InvocationModel', () => {
             const response = await model.getResponse(context, undefined);
             expect(response).to.deep.equal({ invocationId: 'testInvocId', outputData: [], returnValue: undefined });
         });
+
+        // https://github.com/Azure/azure-functions-nodejs-library/issues/210
+        it('Missing binding', async () => {
+            const model = new InvocationModel({
+                invocationId: 'testInvocId',
+                metadata: {
+                    name: 'testFuncName',
+                    bindings: {
+                        httpTrigger1: {
+                            type: 'httpTrigger',
+                            direction: 'in',
+                        },
+                        $return: {
+                            type: 'http',
+                            direction: 'out',
+                        },
+                    },
+                },
+                request: {
+                    inputData: [
+                        {
+                            name: 'httpTriggerMissing',
+                        },
+                    ],
+                },
+                log: testLog,
+            });
+            await expect(model.getArguments()).to.be.rejectedWith(
+                'Failed to find binding "httpTriggerMissing" in bindings "httpTrigger1, $return".'
+            );
+        });
     });
 });