-
Notifications
You must be signed in to change notification settings - Fork 22
SDK Binding GA Changes #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Adding ServiceBus Trigger Chnages * Adding ServiceBus Trigger Chnages * Fixing the unit tests and version update * Staging the new veriosn
* Adding ServiceBus Trigger Chnages * Adding ServiceBus Trigger Chnages * Fixing the unit tests and version update * Staging the new veriosn
| ], | ||
| "engines": { | ||
| "node": ">=18.0" | ||
| "node": ">=20.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that only Node 20 apps will be able to download the latest library version, right? We could also look at bumping the undici major version now (or removing that dependency all together)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets discuss this in Scrum today, should we bump the version?
| "watch": "webpack --watch --mode development" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/functions-extensions-base": "0.2.0-preview", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should release a non-preview version of the base extension for GA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Catch. I will create a PR there.
This PR introduces support for SDK binding through modelBindingData and collectionModelBindingData parameters in the Azure Functions Node.js library, along with ServiceBus trigger enhancements.
Key Changes
Core RPC Data Conversion Enhancement
Added modelBindingData support: Enhanced fromRpcTypedData to handle individual model binding data objects with automatic client creation through ResourceFactoryResolver
Added collectionModelBindingData support: Added support for collections of model binding data objects, processing the first item in the collection as the source
Error handling: Comprehensive error handling with user-friendly messages when extensions library is not registered
Resource factory integration: Integration with @azure/functions-extensions-base for automatic SDK client creation
ServiceBus Trigger Enhancements
Type flexibility: Updated ServiceBusQueueHandler to accept unknown | any for broader message type compatibility
Auto-complete control: Added autoCompleteMessages option for controlling automatic message completion
SDK binding flag: Added sdkBinding boolean option for enabling SDK-based operations