Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Worker V2] Fail gracefully on invalid http output #268

Closed
mhoeger opened this issue Dec 3, 2019 · 0 comments
Closed

[Worker V2] Fail gracefully on invalid http output #268

mhoeger opened this issue Dec 3, 2019 · 0 comments
Assignees

Comments

@mhoeger
Copy link
Contributor

mhoeger commented Dec 3, 2019

Fail gracefully on invalid output for http response. Especially because breaking change, need very explicit error message.
#264

Currently, this:

Exception: TypeError: Cannot create property 'headers' on string 'http output'
Stack: TypeError: Cannot create property 'headers' on string 'http outpu'
    at Object.toRpcHttp [as converter] (D:\home\SiteExtensions\Functions\32bit\workers\node\worker-bundle.js:19813:25)
    at resultCallback (D:\home\SiteExtensions\Functions\32bit\workers\node\worker-bundle.js:17876:70)
    at InvocationContext.done (D:\home\SiteExtensions\Functions\32bit\workers\node\worker-bundle.js:19685:13)
    at D:\home\SiteExtensions\Functions\32bit\workers\node\worker-bundle.js:17915:47
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Should check if output is object or not and give appropriate recommendation.

@mhoeger mhoeger changed the title Fail gracefully on invalid http output [Worker V2] Fail gracefully on invalid http output Dec 3, 2019
@mhoeger mhoeger self-assigned this Dec 4, 2019
@mhoeger mhoeger added this to the Functions Sprint 64 milestone Dec 4, 2019
@mhoeger mhoeger closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant