-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix return output binding logic #264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of scope for timeline
fabiocav
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please make sure documentation items are tracked as well?
mhoeger
added a commit
to mhoeger/azure-functions-nodejs-worker
that referenced
this pull request
Jan 14, 2020
* updates to make 2.0 worker 1.0 compatible * split validation logic so it's both v1 and v2 compatible * hard-coded solution to camelCase timer trigger while proper fix is out of scope for timeline * added test * adding unit test * properly convert data when defined as output array * testing both v1 behavior and v2 behavior * dont code without intellisense * remove e2e test until have better test on functions host v2 and v3 * fix worker validation logic and warning message on ts changes * add tests
mhoeger
added a commit
that referenced
this pull request
Jan 15, 2020
* updates to make 2.0 worker 1.0 compatible * split validation logic so it's both v1 and v2 compatible * hard-coded solution to camelCase timer trigger while proper fix is out of scope for timeline * added test * adding unit test * properly convert data when defined as output array * testing both v1 behavior and v2 behavior * dont code without intellisense * remove e2e test until have better test on functions host v2 and v3 * fix worker validation logic and warning message on ts changes * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #232