Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return output binding logic #264

Merged
merged 11 commits into from
Dec 2, 2019

Conversation

mhoeger
Copy link
Contributor

@mhoeger mhoeger commented Dec 2, 2019

Resolves #232

@mhoeger mhoeger requested review from yojagad and fabiocav December 2, 2019 01:03
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please make sure documentation items are tracked as well?

@mhoeger
Copy link
Contributor Author

mhoeger commented Dec 2, 2019

#265

@mhoeger mhoeger merged commit 648a372 into Azure:v2.x Dec 2, 2019
mhoeger added a commit to mhoeger/azure-functions-nodejs-worker that referenced this pull request Jan 14, 2020
* updates to make 2.0 worker 1.0 compatible

* split validation logic so it's both v1 and v2 compatible

* hard-coded solution to camelCase timer trigger while proper fix is out of scope for timeline

* added test

* adding unit test

* properly convert data when defined as output array

* testing both v1 behavior and v2 behavior

* dont code without intellisense

* remove e2e test until have better test on functions host v2 and v3

* fix worker validation logic and warning message on ts changes

* add tests
mhoeger added a commit that referenced this pull request Jan 15, 2020
* updates to make 2.0 worker 1.0 compatible

* split validation logic so it's both v1 and v2 compatible

* hard-coded solution to camelCase timer trigger while proper fix is out of scope for timeline

* added test

* adding unit test

* properly convert data when defined as output array

* testing both v1 behavior and v2 behavior

* dont code without intellisense

* remove e2e test until have better test on functions host v2 and v3

* fix worker validation logic and warning message on ts changes

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants