Set-Cookie support in http #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoeger
changed the title
pragnagopa
reviewed
May 20, 2019
src/WorkerChannel.ts
Outdated
| @@ -139,7 +139,8 @@ export class WorkerChannel implements IWorkerChannel { | |||
| } | |||
| if (result) { | |||
| if (result.return) { | |||
| response.returnValue = toTypedData(result.return); | |||
| let returnBinding = info.getReturnBinding(); | |||
| response.returnValue = returnBinding ? returnBinding.converter(result.return) : toTypedData(result.return); | |||
There was a problem hiding this comment.
Add test verify this code path.
pragnagopa
reviewed
May 20, 2019
pragnagopa
reviewed
May 20, 2019
pragnagopa
reviewed
May 20, 2019
pragnagopa
reviewed
May 20, 2019
pragnagopa
reviewed
May 20, 2019
|
Please add a E2E test. |
…e-worker-protobuf. Branch: dev. Commit:bd4379767d6c25be59dfbe91dc57f6c03af9968b Tag: v1.1.0
|
@pragnagopa - as discussed offline, i've manually verified these changes. opening a separate work item for e2e tests so that we can get the changes out the upcoming release |
pragnagopa
reviewed
Jun 18, 2019
| @@ -11,6 +11,7 @@ package AzureFunctionsRpcMessages; | |||
|
|
|||
| import "google/protobuf/duration.proto"; | |||
| import "identity/ClaimsIdentityRpc.proto"; | |||
| import "shared/NullableTypes.proto"; | |||
There was a problem hiding this comment.
|
note: e2e tests in devops temporarily failing for core tools 2.7.1385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf PR: Azure/azure-functions-language-worker-protobuf#32
Host PR: Azure/azure-functions-host#4317
For issue: Azure/azure-functions-host#2737
Resolves: #222