Add new SameSite property and tests #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoeger
commented
Mar 10, 2020
| @@ -4,12 +4,6 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Moving Http scenario helper methods to "HttpHelpers" not utilities
This was referenced Mar 11, 2020
mhoeger
commented
Mar 17, 2020
yojagad
approved these changes
Mar 17, 2020
mhoeger
added a commit
that referenced
this pull request
Jun 2, 2020
* Add new SameSite property and tests * publish test results * update image and publish * try again * put test outputs in correct location * always publish results * fixing http tests * fixing tests * change test output cookie order * disabling samesite none cookie test until e2e is repaired
mhoeger
added a commit
that referenced
this pull request
Jun 3, 2020
* Add new SameSite property and tests (#286) * Add new SameSite property and tests * publish test results * update image and publish * try again * put test outputs in correct location * always publish results * fixing http tests * fixing tests * change test output cookie order * disabling samesite none cookie test until e2e is repaired * fix merge * fix node 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Azure/azure-functions-host#4890
Resolves Azure/azure-functions-host#5384
Most of the changes in this PR is related to fixing the end to end tests to make more sense. RpcHttpConverters has the behavior-changing changes.